-
Notifications
You must be signed in to change notification settings - Fork 749
Fix for 3dsMax Python #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Importing clr in 3dsMax python, causes the application to crash on GetTypes from certain assemblies.
There should be some error checking on the domain assembly lookup, to avoid "exploding", when running in some embed python dcc (in this case 3dsmax). This is what this pull request does. |
The travis and appveyor CI builds are failing with this error: assemblymanager.cs(70,37): error CS1056: Unexpected character `$' Could you refactor so as not to use C# 6 features please? (only a small change, and easier than converting the project to C# 6 for now) thanks, |
Sure no problem. A Qui, 7 de Jan de 2016, 09:21, Tony Roberts notifications@github.com
|
Failing on AppVeyor py26, but not due to code changes. |
Sorry, I didn't notice before but this pull request is against the master branch. All pull requests need to be against the develop branch (which is merged into master prior to a release). |
Ok, I will make one against the develop. Are you guys using simple git flow Tony Roberts notifications@github.com escreveu no dia quinta, 7/01/2016
|
About as simple as it gets. The develop branch is for development; no problem accepting small commits directly on there, no need for a feature branch (although for more major features I would use a feature branch). Master is always buildable/releasable. I'll move these commits to develop and create a new PR. cheers, |
If I haven't screwed anything up your changes should now be in #115 :) |
Thanks ;). Tony Roberts notifications@github.com escreveu no dia quinta, 7/01/2016
|
Importing clr in 3dsMax python, causes the application to crash on
GetTypes from certain assemblies.