-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Remove shebang line from easy_install generated python scripts on Windows only #148673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148673
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a3eefe0 with merge base c0f1557 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
d9cb0ed
to
5db546f
Compare
5db546f
to
79df6bb
Compare
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
79df6bb
to
a3eefe0
Compare
@taras-janea Is this reproductive for wheel or conda builds? And if easy_install is deprecated, perhaps better solution would be to move to a supported framework ? |
@malfet thank you for your question. This is reproductive for conda distributions from https://conda.anaconda.org - they already contain an invalid absolute shebang line. Regarding deprecated easy_install module, it's not used directly in PyTorch, but is used by setuptools which in turn is used by setup.py. I agree that removing the easy_install dependency would be beneficial. Regardless, the changes in the PR are still needed to ensure the invalid shebang line is removed, as it is already present in conda distributions. You may find more details in the issue comment. |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Adding |
Fixes
On windows only, for install step: remove shebang line from python scripts generated by
easy_install
.cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex