-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Move code out of individual token linters #152256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152256
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c259c5a with merge base 4cd6e96 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This is a second pure refactoring after the previous. I originally tried did this all in one pull request, but it broke the 2000 line delta rule. This one brings in most of the functionality on the two linters (set_linter and docstring_linter) into the main linter subdirectory, so it can be used by the upcoming "multilinter" (which covers anything that can be reported on using tokenization.) |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ghstack-source-id: 149e094 Pull Request resolved: pytorch#152256
Stack from ghstack (oldest at bottom):
cc @ezyang @gchanan