[refactor] move materialize_as_graph to _higher_order_ops/utils.py #154070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154070
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9e7f510 with merge base d865b78 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 21, 2025
…utils.py" [ghstack-poisoned]
Skylion007
reviewed
May 22, 2025
| @@ -969,6 +972,36 @@ def call_op(op: Union[OpOverload, HopInstance], args, kwargs): | |||
| return op(*bound_args, **bound_kwargs) | |||
|
|
|||
|
|
|||
| def materialize_as_graph( | |||
| fn: Callable, | |||
There was a problem hiding this comment.
This is a bare callable, please add some typing support here for return value and input params with ParamSpec?
This was referenced May 23, 2025
zou3519
approved these changes
May 27, 2025
…utils.py" [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
…ytorch#154070) Pull Request resolved: pytorch#154070 Approved by: https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):