Skip to content

[BE][1/16] fix typos in torch/ #156311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 29 commits into from
Closed

[BE][1/16] fix typos in torch/ #156311

wants to merge 29 commits into from
+129 −123

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

@XuehaiPan
Update
73ec525 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156311

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f4920f3 with merge base effe376 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mobile release notes category label Jun 18, 2025
This was referenced Jun 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100, Limited CI for symmetric memory tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100, Limited CI for symmetric memory tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: Limited CI for distributed tests on H100, Limited CI for symmetric memory tests on H100

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100, Limited CI for symmetric memory tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Update
f4920f3 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #157636

pytorchmergebot pushed a commit that referenced this pull request Jul 9, 2025
@XuehaiPan @pytorchmergebot
[BE] fix typo in torch/distributed/tensor/: childs -> children (#156609)
ffe11b2 
Pull Request resolved: #156609
Approved by: https://github.com/wanchaol, https://github.com/cyyever
ghstack dependencies: #156311
pytorchmergebot pushed a commit that referenced this pull request Jul 9, 2025
@XuehaiPan @pytorchmergebot
[BE][2/6] fix typos in test/ (test/test_*.py) (#157636)
fc0376e 
Pull Request resolved: #157636
Approved by: https://github.com/yewentao256, https://github.com/mlazos
ghstack dependencies: #156311, #156609
@github-actions github-actions bot deleted the gh/XuehaiPan/311/head branch August 9, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

@sraikund16 sraikund16 Awaiting requested review from sraikund16

@soulitzer soulitzer Awaiting requested review from soulitzer

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby

@wschin wschin Awaiting requested review from wschin

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/h100-symm-mem ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @albanD @pytorchbot