Skip to content

[BE][2/16] fix typos in torch/ (torch/_*/) #156312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

[BE][2/16] fix typos in torch/ (torch/_*/) #156312

wants to merge 34 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 18, 2025 •
edited
Loading

@XuehaiPan
Update
aa22f33 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156312

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 100 Pending

As of commit 8a5b585 with merge base e90148c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 18, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][2/16] fix typos in torch/ (torch/_*/)
82d2478 
ghstack-source-id: 4404151
Pull-Request: pytorch#156312
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][2/16] fix typos in torch/ (torch/_*/)
3435057 
ghstack-source-id: 4404151
Pull-Request: pytorch#156312
@XuehaiPan
Update
c4f1a09 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][2/16] fix typos in torch/ (torch/_*/)
5a0ccab 
ghstack-source-id: be3ef8c
Pull-Request: pytorch#156312
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 18, 2025
@XuehaiPan
[BE][2/16] fix typos in torch/ (torch/_*/)
feb8656 
ghstack-source-id: be3ef8c
Pull-Request: pytorch#156312
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor-rocm / rocm-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), inductor-rocm / rocm-py3.10-inductor / test (inductor, 1, 2, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot revert -m "landrace" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 12, 2025
@pytorchmergebot
Revert "[BE][2/16] fix typos in torch/ (torch/_*/) (#156312)"
e15f424 
This reverts commit 7a92b51.

Reverted #156312 on behalf of https://github.com/XuehaiPan due to landrace ([comment](#156312 (comment)))
@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 12, 2025
@XuehaiPan
Update
8a5b585 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 12, 2025
@XuehaiPan
[BE][2/16] fix typos in torch/ (torch/_*/)
2a91a94 
ghstack-source-id: f02c038
Pull-Request: pytorch#156312
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/312/head branch August 12, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@zou3519 zou3519 Awaiting requested review from zou3519

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@laithsakka laithsakka Awaiting requested review from laithsakka

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category release notes: quantization release notes category Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @albanD @pytorchmergebot @pytorchbot