Skip to content

[BE][1/5] fix typos in aten/ #157550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

[BE][1/5] fix typos in aten/ #157550

wants to merge 15 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 3, 2025 •
edited
Loading

@XuehaiPan
Update
a76c3e4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157550

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6d2a855 with merge base d76323d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 3, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 3, 2025
@XuehaiPan
[BE][1/5] fix typos in aten/
6889e90 
ghstack-source-id: a2f7e95
Pull-Request: pytorch#157550
@XuehaiPan XuehaiPan requested a review from soulitzer July 3, 2025 15:20
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jul 3, 2025
@XuehaiPan
Update
4fb5dd2 
[ghstack-poisoned]
This was referenced Jul 4, 2025
Open
Closed
Closed
Closed
Closed
Closed
@XuehaiPan
Update
be9c71a 
[ghstack-poisoned]
@XuehaiPan
Update
46101c7 
[ghstack-poisoned]
@XuehaiPan
Update
609a589 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 12, 2025
@XuehaiPan
[BE][1/5] fix typos in aten/
2233c4e 
ghstack-source-id: dc7a4d7
Pull-Request: pytorch#157550
albanD
albanD approved these changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@XuehaiPan
Update
7c97dae 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 15, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@XuehaiPan
Update
af12f70 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #157552

@XuehaiPan
Update
e295d4d 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 16, 2025
@XuehaiPan
[BE][1/5] fix typos in aten/
f935d46 
ghstack-source-id: 28e47df
Pull-Request: pytorch#157550
@XuehaiPan
Update
6d2a855 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 17, 2025
@XuehaiPan
[BE][1/5] fix typos in aten/
4ab1f01 
ghstack-source-id: d8fa647
Pull-Request: pytorch#157550
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #157552

pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2025
@XuehaiPan @pytorchmergebot
[BE][2/5] fix typos in aten/ (aten/src/ATen/native/) (#157551)
f57ef62 
Pull Request resolved: #157551
Approved by: https://github.com/albanD
ghstack dependencies: #156605, #157637, #157550
pytorchmergebot pushed a commit that referenced this pull request Jul 17, 2025
@XuehaiPan @pytorchmergebot
[BE][3/5] fix typos in aten/ (aten/src/ATen/native/) (#157552)
d5af0ec 
Pull Request resolved: #157552
Approved by: https://github.com/albanD
ghstack dependencies: #156605, #157637, #157550, #157551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yewentao256 yewentao256 yewentao256 left review comments

@albanD albanD albanD approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@EikanWang EikanWang Awaiting requested review from EikanWang EikanWang is a code owner

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged module: amp (automated mixed precision) autocast open source release notes: vulkan release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuehaiPan @pytorchmergebot @albanD @yewentao256 @pytorchbot