-
Notifications
You must be signed in to change notification settings - Fork 24.9k
[build] pin setuptools>=77
to enable PEP 639
#158104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/XuehaiPan/365/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158104
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 228 PendingAs of commit dde688d with merge base be53f60 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: d8f9f75 Pull-Request: pytorch#158104
ghstack-source-id: e5138b4 Pull-Request: pytorch#158104
ghstack-source-id: 32a4865 Pull-Request: pytorch#158104
ghstack-source-id: 9a3c1e9 Pull-Request: pytorch#158104
ghstack-source-id: b1f18b3 Pull-Request: pytorch#158104
Adding |
ghstack-source-id: 8ffb2cf Pull-Request: pytorch#158104
ghstack-source-id: 79378ae Pull-Request: pytorch#158104
ghstack-source-id: 443804a Pull-Request: pytorch#158104
Since PyTorch 2.8.0 has been released, I wonder if there are any blockers or unresolved concerns about this PR? cc @albanD |
To me there are two main concers:
|
See the PR description #158104 (comment), we will need to pin either
I will try to remove the pins as much as I can in this PR, and then get back to you. |
ghstack-source-id: 005d39e Pull-Request: pytorch#158104
ghstack-source-id: 8429e5c Pull-Request: pytorch#158104
PEP 639: peps.python.org/pep-0639
setuptools
v77 adds PEP 639 support for SPDX expression aspackage.license
inpyproject.toml
and also deprecated TOML-table-basedpackage.license
. That depression will be converted to an error in the future.Note that
setuptools<77
does not support SPDX-basedpackage.license
whilesetuptools>=77
will error for non-SPDX-basedpackage.license
in the future. We need an explicit version pin forsetuptools>=77
(or pinsetuptools<77
).See also:
project.license
deprecation if v77 unavailable pypa/setuptools#4903Stack from ghstack (oldest at bottom):
setuptools<80.0
#156049setuptools>=77
to enable PEP 639 #158104cc @malfet @seemethere @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela