Skip to content

Several fixed issues/PRs that might be closed #9948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qinhanmin2014 opened this issue Oct 18, 2017 · 6 comments · Fixed by #9954
Closed

Several fixed issues/PRs that might be closed #9948

qinhanmin2014 opened this issue Oct 18, 2017 · 6 comments · Fixed by #9954

Comments

@qinhanmin2014
Copy link
Member

qinhanmin2014 commented Oct 18, 2017

I'm not doing this intentionally. Below are just my findings this year when searching for issues/PRs and reading other's code. So not sure how serious the problem is.

#4964 might be closed.
It is fixed in #6841
#5839 might be closed.
It is fixed in #6841
#7861 might be closed.
It is fixed in #8071
#7794 might be closed.
It is fixed in #9188
#9821 might be closed.
It is fixed in #9847
#6752 might be closed.
It is fixed in #8066
#5588 might be closed.
It is fixed in #8066
#3506 might be closed.
It is fixed in #8066

In the long run, I think it might be important to have someone check all the issues and PRs, especially some old issues/PRs. Compared with similar projects like numpy/scipy/pandas/matplotlib/tensorflow (many of them just 100+ PRs), seems that scikit-learn has to many PRs (nearly 600).

@jnothman
Copy link
Member

Yes, we're not very good at closing PRs. We also don't have as much regular personnel availability as some/all of those projects. We are used by a more focused (and more applied) user group, so don't get the same contributor pool or quality, necessarily.

I don't think having excess open issues/PRs is terrible, though. Why do you consider it important?

We have periodically gone through issues. PRs can be harder. Part of this might be a more robust labelling scheme, but we've found they're hard to maintain.

I'll look at these specific issues/PRs later.

@qinhanmin2014
Copy link
Member Author

Why do you consider it important?

no specific reason, maybe just the increasing cost of keeping track of so many issues/PRs from your side.

I hesitate a lot before posting this issue, so if there is something inappropriate, kindly regret me, at least my intention is not bad :)

@lesteve
Copy link
Member

lesteve commented Oct 18, 2017

My personal take on this: github issues are like google search results. If you are not in the first page, it is pretty much the same as not existing. If an issue/PR is really important someone will bump into it creating some activity and the issue will be back on the first page.

Yes it would feel a bit better to have issues closed when appropriate (I generally insist on using "Fix #issueNumber" in PR descriptions) but 1. this is pretty much a lost cause 2. this is taking time away from more important problems.

@lesteve
Copy link
Member

lesteve commented Oct 18, 2017

I closed the PRs you mentioned, closing.

@lesteve lesteve closed this as completed Oct 18, 2017
@qinhanmin2014
Copy link
Member Author

Thanks :) I think at some point, we might consider to improve contributor guide or even PR template to tell contributors to use Fixes and Closes to point to relevant issues / PRs. I sometimes imagine if I am at your point, I'll be so frustrating to merge something like 7910 because I need to manually close 3 issues/PRs. Anyway, ignore the message if everything seems fine from your perspective.

@jnothman
Copy link
Member

PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants