-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG] Prevent hyphenation in parameter description #15499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Prevent hyphenation in parameter description #15499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull-request !
A small comment:
@@ -823,6 +823,10 @@ div.body img { | |||
height: unset!important; /* Needed because sphinx sets the height */ | |||
} | |||
|
|||
div.body dd > p { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change is not located in doc/themes/scikit-learn/static/nature.css_t
as suggested in #12941 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that previous comment sort of threw me for a loop.
I think there was a change to which stylesheet the documentation uses since that last comment. doc/themes/scikit-learn-modern/static/css/theme.css
was the only stylesheet that I could change that would eventually be linked with the page in question.
I did a quick search, and I think it happened in this merge: #14849
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah @thomasjpfan rewrote the frontend / css
we should wait for Circle to render this so we can confirm it fixed the issue. |
hm ok Circle will probably not catch up today though :( |
Co-authored-by: Shruthi Kubatur <shruthi.ks05@gmail.com>
…tiskg/scikit-learn into fix_doc_hyphenation_loftiskg
Hi @loftiskg, the checks are failing for temporary issues on azure. |
…into fix_doc_hyphenation_loftiskg
@cmarmo sure thing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @loftiskg ! |
Reference Issues/PRs
Fixes #12941
What does this implement/fix? Explain your changes.
Added CSS to prevent line breaking in the middle of a word in a parameter description.
Any other comments?
@skubatur co-authored this request with me.