CI Add CPython 3.13 free-threaded manylinux wheel #29247
Conversation
| @@ -59,6 +59,13 @@ if [[ "$GITHUB_EVENT_NAME" == "schedule" || "$CIRRUS_CRON" == "nightly" ]]; then | |||
| export CIBW_BUILD_FRONTEND='pip; args: --pre --extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple"' | |||
| fi | |||
|
|
|||
| if [[ "$CIBW_FREE_THREADED_SUPPORT" =~ [tT]rue ]]; then | |||
There was a problem hiding this comment.
The regex here is because I am not too sure about yaml value plus its env var translation. It looks like you can use true and True in the yaml and the env variable will be "true". You could imagine using "True" (a string rather than a boolean) in the yaml and that should still work I think.
There was a problem hiding this comment.
I haven't thought too much about it, but if we merge this PR, there may be a risk that we upload a CPython 3.13 free-thread wheel to PyPI by mistake. CPython 3.13 is supposed to be schedule in October 2024 and scikit-learn 1.6 release will probably happen November/December 2024, so we may be fine based on this.
The pypi wheel uploader workflow should fail because it checks the number of files to upload. If that happens, we can update it at the time of the release to either update the expected number of wheels to include the free-threaded variants or filter them out of the final upload.
| @@ -154,7 +161,8 @@ jobs: | |||
|
|
|||
| - name: Build and test wheels | |||
| env: | |||
| CIBW_PRERELEASE_PYTHONS: ${{ matrix.prerelease }} | |||
There was a problem hiding this comment.
What happened to the prerelease variable? Was it not used anywhere else?
It looked like this PR was renaming it from matrix.prerelease to matrix.prerelease_pythons which made me expect to see some other renames as well.
There was a problem hiding this comment.
I think matrix.prerelease was used at one point for Python 3.12 before Python 3.12 was released and then once Python 3.12 was released, the line was removed
|
I am going to merge my own PR with 1.75 approval(s). My main worry was the potential side-effect on PyPI and according to #29247 (review) it should be fine. At worst we upload a free-threaded Python 3.13 wheel to PyPI that people are unlikely to use. I am reasonably confident everything is will be fine and I will deal with the consequences if anything goes awry 😉 |
This adds a CPython 3.13 free-threaded manylinux wheel.
I haven't thought too much about it, but if we merge this PR, there may be a risk that we upload a CPython 3.13 free-thread wheel to PyPI by mistake. CPython 3.13 is supposed to be schedule in October 2024 and scikit-learn 1.6 release will probably happen November/December 2024, so we may be fine based on this.
Related to #28978.