Skip to content

support GOOGLE_APPLICATION_CREDENTIALS env variable #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2018
Merged

support GOOGLE_APPLICATION_CREDENTIALS env variable #123

merged 2 commits into from
Oct 30, 2018

Conversation

philsch
Copy link
Contributor

@philsch philsch commented Oct 15, 2018

Support to use the GOOGLE_APPLICATION_CREDENTIALS environment variable instead of the provider credentials parameters as described in #122.

pickypg
pickypg approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pmuens
pmuens approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philsch 👍

LGTM :shipit:

@pmuens pmuens merged commit e45ec2d into serverless:master Oct 30, 2018
@upodroid upodroid mentioned this pull request Nov 2, 2020
Closed
@rothso rothso mentioned this pull request Dec 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pickypg pickypg pickypg approved these changes

@pmuens pmuens pmuens approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philsch @pickypg @pmuens