Skip to content

Fix authentication and logs #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix authentication and logs #241

wants to merge 2 commits into from

Conversation

upodroid
Copy link

@upodroid upodroid commented Nov 2, 2020

Fixed auth mechanisms and Logs.

I'm not great at JS :( The changes work but i'm stuck on rejigging the test.

Fixes: #123
Fixes: #234
Fixes: #238

medikoo
medikoo reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @upodroid for the effort. I'll mark this as help wanted, so hopefully someone will jump in with helping hand

@rothso rothso mentioned this pull request Dec 26, 2020
Merged
@medikoo medikoo closed this in #244 Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@medikoo medikoo medikoo left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime nodejs10 No key or keyFile set
2 participants
@upodroid @medikoo