fix: Authentication and Logs #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking my pr and making it ready for submission |
medikoo
suggested changes
Dec 28, 2020
There was a problem hiding this comment.
Thank you!
Let's also maybe add engines setting as here: https://github.com/serverless/serverless/blob/ff253e32dd5e9c17f46f5a359ebfb9007b6ffa7d/package.json#L218-L220 to package.json
While it's not perfectly functional it allows to quickly determine what Node.js version support is provided
medikoo
approved these changes
Dec 30, 2020
troykelly
pushed a commit
to Pioneera/serverless-google-cloudfunctions
that referenced
this pull request
Jan 12, 2021
fix: Authentication and Logs (serverless#244)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the excellent work done by @upodroid (resolves #241). I updated the tests so they would pass again and can confirm the changes still work.
Recap
project.credentialsisn't provided (fixes support GOOGLE_APPLICATION_CREDENTIALS env variable #123, resolves Rely on google auth to get credentials if not set #183, fixes No key or keyFile set #234)