Skip to content

Fixed various issues with L4 and WB take 2 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Fixed various issues with L4 and WB take 2 #576

wants to merge 10 commits into from

Conversation

David-OConnor
Copy link
Contributor

Fixes #555, #563, #565, #567, #570, #572, and #575.

See #573; "unrecoverable" git errors.

@github-actions
Copy link

Memory map comparison

@David-OConnor
Copy link
Contributor Author

The 412 RTC changes don't appear to be taking effect, after building and inspecting the module. Any ideas?

@adamgreig
Copy link
Member

I guess the problem is with the _include: stm32l4x2.yaml at the end; I suspect that will overwrite things you don't want to overwrite, such as _svd, in the parent YAML. I don't think it's intended that you'd import a top-level YAML into another top-level YAML, so that's my guess as to the problem. Try just including the relevant bits of that file directly?

By the way, instead of changing the SVD zip file (which should ideally be exactly as-downloaded from ST), you can modify extract.sh to add a new copy line to create a new identical SVD for L412, like https://github.com/stm32-rs/stm32-rs/blob/master/svd/extract.sh#L9

@David-OConnor
Copy link
Contributor Author

Done! That sorted it. Marking as draft for now; running into empty built-libs on L4x3, L412, and WB55, for reasons I haven't yet determined.

@David-OConnor David-OConnor marked this pull request as draft June 18, 2021 01:22
@David-OConnor
Copy link
Contributor Author

David-OConnor commented Jun 18, 2021

Fixed the not-building problems; various syntax errors, eg access read instead of read-only. Currently, some of the L412 RTC reg changes are taking place, but not others, upon generated-module inspection. I wonder if this is an order-error, eg if a reg is added to a place that's not yet freed from a later-modified reg. (?)

For example, CR is showing up at its original location of 0x08 in the generated lib, despite this line:

  CR:
    _modify:
      addressOffset: 0x18
    _add:
    ...

@David-OConnor
Copy link
Contributor Author

Fixed most L412 RTC problems; syntax error re ordering of _modify and the reg name. Currently looks good, except 3 out of 4 of the added regs (at the end of the block) are not adding. Maybe need to increase size of reg block somehow?

@David-OConnor David-OConnor marked this pull request as ready for review June 21, 2021 03:48
@David-OConnor
Copy link
Contributor Author

Broke git again

#576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L41x and L42x use diff RTC regs
2 participants