Skip to content

STM32L4x3 USB points to wrong addr #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
David-OConnor opened this issue Jun 3, 2021 · 1 comment
Closed

STM32L4x3 USB points to wrong addr #565

David-OConnor opened this issue Jun 3, 2021 · 1 comment

Comments

@David-OConnor
Copy link
Contributor

David-OConnor commented Jun 3, 2021 •
edited
Loading

https://github.com/stm32-rs/stm32-rs-nightlies/blob/master/stm32l4/src/stm32l4x3/mod.rs#L1347

Should be 0x4000_6800. The current one is the USB SRAM address.

L4x2 PAC is correct. L4x1 PAC doesn't have USB. L4x6 PAC uses OTG. L4x5 PAC also has this error, but if I understand correctly, shouldn't even have this periph since it uses the OTG periph.

To fix, could copy + paste L4x2 USB module. Should be the same.
This was referenced Jun 3, 2021
Closed
Closed
This was referenced Jun 18, 2021
Closed
Closed
Closed
Merged
bors bot added a commit that referenced this issue Aug 18, 2021
@bors @David-OConnor @adamgreig
Merge #580
a02b1a8 
580: L4 and WB fixes r=adamgreig a=David-OConnor

Fixes #555, #563, #565, #567, #570, #572, and #575.

See #578; "unrecoverable" git errors.

Not currently working:

- Last 3 (by address) added L412 RTC regs are not adding
- WB HSEM and IPCC renamed regs are not changing
- BCDR field added to USB

Removed the L4x2 `USB_FS` rename to `USB`: the RM calls it `USB_FS`. Previous justification, from a code comment: 
> we call the resulting peripheral `USB` instead of `USB-FS` to be aligned with `mvirkkunen/stm32f103-usb`

The *peripheral* is called `USB`; the interrupt is called `USB_FS`.

Co-authored-by: David O'Connor <david.alan.oconnor@gmail.com>
Co-authored-by: Adam Greig <adam@adamgreig.com>
@adamgreig
Copy link
Member

Closed by #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamgreig @David-OConnor