-
Notifications
You must be signed in to change notification settings - Fork 241
styles update #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styles update #116
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think this is good to go, though I haven't merged it yet |
Other things I noticed: On blog example, link text is hard to read in dark mode Also on the error.html example And the breaking out of layouts example: |
Can I request a dark/light mode toggle, please? |
I've gone through all the exercises and adjusted the colors so it looks both good/acceptable in light/dark mode. I also noticed a few things along the way, for which I'll open some issues. It mainly boils down to "Svelte core tutorial labels look shitty", "things are not loaded" and "alerts are broken". |
Updates styles to closer match site-kit and adds support for dark mode.
This adds a temporary site-kit version (the same as in the current Kit repo), because there's no deployed version of the new site-kit yet. Once that's done, the temporary version should be removed and then we can merge this.