This repository was archived by the owner on Aug 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 238
styles update #116
Merged
Merged
styles update #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think this is good to go, though I haven't merged it yet |
Other things I noticed: On blog example, link text is hard to read in dark mode Also on the error.html example And the breaking out of layouts example: |
Can I request a dark/light mode toggle, please? |
I've gone through all the exercises and adjusted the colors so it looks both good/acceptable in light/dark mode. I also noticed a few things along the way, for which I'll open some issues. It mainly boils down to "Svelte core tutorial labels look shitty", "things are not loaded" and "alerts are broken". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates styles to closer match site-kit and adds support for dark mode.
This adds a temporary site-kit version (the same as in the current Kit repo), because there's no deployed version of the new site-kit yet. Once that's done, the temporary version should be removed and then we can merge this.