Skip to content

styles update #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 13, 2022
Merged

styles update #116

merged 15 commits into from
Dec 13, 2022

Conversation

dummdidumm
Copy link
Member

Updates styles to closer match site-kit and adds support for dark mode.

This adds a temporary site-kit version (the same as in the current Kit repo), because there's no deployed version of the new site-kit yet. Once that's done, the temporary version should be removed and then we can merge this.

@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 11:20AM (UTC)

@Rich-Harris
Copy link
Member

I think this is good to go, though I haven't merged it yet

@Rich-Harris
Copy link
Member

found one thing that needs fixing

image

@Rich-Harris
Copy link
Member

another

image

@geoffrich
Copy link
Member

Another thing (maybe more obvious with dark mode?) - the bullets on a <ul> seem to have fixed position and stop lining up with the list items

image

@geoffrich
Copy link
Member

Other things I noticed:

On blog example, link text is hard to read in dark mode
image

Also on the error.html example
image

And the breaking out of layouts example:
image

@jacob-8
Copy link

jacob-8 commented Dec 13, 2022

Can I request a dark/light mode toggle, please?

@dummdidumm
Copy link
Member Author

dummdidumm commented Dec 13, 2022

I've gone through all the exercises and adjusted the colors so it looks both good/acceptable in light/dark mode. I also noticed a few things along the way, for which I'll open some issues. It mainly boils down to "Svelte core tutorial labels look shitty", "things are not loaded" and "alerts are broken".
I'll merge this since this is certainly an improvement over the existing state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants