Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/symfony
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.28
Choose a base ref
...
head repository: symfony/symfony
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.29
Choose a head ref
  • 15 commits
  • 17 files changed
  • 6 contributors

Commits on Jul 27, 2021

  1. Bump Symfony version to 4.4.29

    fabpot committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    1ab8a0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dbc28d0 View commit details
    Browse the repository at this point in the history
  3. [HttpFoundation] Fixed type mismatch

    Toflar authored and derrabus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    31591c3 View commit details
    Browse the repository at this point in the history
  4. bug #42289 [HttpFoundation] Fixed type mismatch (Toflar)

    This PR was squashed before being merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Fixed type mismatch
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | #42290
    | License       | MIT
    | Doc PR        | -
    
    Fixes
    
    > Argument 1 passed to str_contains() must be of the type string, null given, called in /.../vendor/symfony/http-foundation/Response.php on line 327
    
    in case there's no `cache-control` response header. This doesn't happen by default as the `Response` is initialized with one by default but any class extending from it can adjust that. Technically speaking, it's not disallowed to have no `cache-control` header set.
    
    Want me to add a test for that? :)
    
    Commits
    -------
    
    31591c3 [HttpFoundation] Fixed type mismatch
    derrabus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b68cefa View commit details
    Browse the repository at this point in the history
  5. Remove polyfills from Yaml and Dotenv

    Signed-off-by: Alexander M. Turek <me@derrabus.de>
    derrabus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    08ecbf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09e7d6f View commit details
    Browse the repository at this point in the history
  7. minor #42281 [Console] Readd missing php-doc parameter for constructo…

    …r (brosenberger)
    
    This PR was squashed before being merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Console] Readd missing php-doc parameter for constructor
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  |no
    | Deprecations? |no
    | Tickets       | no
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    partly revert the php constroctur php doc (readd missing php-doc for $name and $description) even if they not that meaningfull
    
    This is needed as Magento2 uses this library and needs all php-doc parameter for interception compilation. if there are any missing parameters (in this case $name and $description) break compile step as the parameters are missmatching the actual parameters:
    ![image](https://user-images.githubusercontent.com/2969243/127111853-671d0f70-e44e-4465-9d2b-54ec80b934ff.png)
    (AbstractConfigOption extends InputOption)
    
    Commits
    -------
    
    09e7d6f [Console] Readd missing php-doc parameter for constructor
    derrabus committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    7f0641f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. bug #42296 [Dotenv][Yaml] Remove PHP 8.0 polyfill (derrabus)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Dotenv][Yaml] Remove PHP 8.0 polyfill
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #42280
    | License       | MIT
    | Doc PR        | N/A
    
    This is a partial revert of #41576 and #41973.
    
    Commits
    -------
    
    08ecbf5 Remove polyfills from Yaml and Dotenv
    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    192e360 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c6d31a View commit details
    Browse the repository at this point in the history
  3. bug #42307 [Mailer] Fixed decode exception when sendgrid response is …

    …202 (rubanooo)
    
    This PR was submitted for the 5.3 branch but it was squashed and merged into the 4.4 branch instead.
    
    Discussion
    ----------
    
    [Mailer] Fixed decode exception when sendgrid response is 202
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4 for features / 4.4, 5.2 or 5.3 for bug fixes <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | Fix #42306 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/releases):
     - Always add tests and ensure they pass.
     - Never break backward compatibility (see https://symfony.com/bc).
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too.)
     - Features and deprecations must be submitted against branch 5.x.
     - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
    -->
    
    Commits
    -------
    
    9c6d31a [Mailer] Fixed decode exception when sendgrid response is 202
    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    4a28597 View commit details
    Browse the repository at this point in the history
  4. minor #42279 missing translations for basque (aetxebeste)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    missing translations for basque
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | yes/no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | Fix #41031 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/releases):
     - Always add tests and ensure they pass.
     - Never break backward compatibility (see https://symfony.com/bc).
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too.)
     - Features and deprecations must be submitted against branch 5.x.
     - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
    -->
    
    Commits
    -------
    
    dbc28d0 missing translations for basque
    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    0c5a79d View commit details
    Browse the repository at this point in the history
  5. Update CHANGELOG for 4.4.29

    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    7388148 View commit details
    Browse the repository at this point in the history
  6. Update CONTRIBUTORS for 4.4.29

    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    5897a3e View commit details
    Browse the repository at this point in the history
  7. Update VERSION for 4.4.29

    fabpot committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    893f5f9 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #42312 from fabpot/release-4.4.29

    released v4.4.29
    fabpot authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    ce674b3 View commit details
    Browse the repository at this point in the history
Loading