Symfony 3.0 proposed backward incompatible changes #11742

javiereguiluz · 2014-08-23T08:21:48Z

This is a meta-issue that groups all the proposed backward incompatible changes for the upcoming Symfony 3.0 version. It includes more information than the 3.0 milestone because sometimes people propose ideas in the comments of the issues and pull requests.

Commands

Make assets:install even smarter and create symlinks by default (without providing the --symlinks option) (ref)
...

Console

As one may want to rely on the asset helper to generate URIs outside from a request (i.e., in a command-line, for sending e-mails), it should not depend on the request service, but rather on request_stack, in order to be available in a wider scope. (ref, related)
InputInterface operates only with arguments passed to the Application. I suggest to add a method that would allow to operate with an input stream (STDIN in case of CLI application). (ref)
Symfony\Component\Console\Output\OutputInteface should include the following methods: isQuiet, isVerbose, isVeryVerbose and isDebug. (ref, ref, [Console] Define isVerbose(), etc. methods in OutputInterface #13086)
~~remove the shell feature (not that useful and bad side-effects see Shell and Doctrine #11750)~~
...

DependencyInjection

~~Remove the concept of "scopes" for services. (ref [DI] Remove deprecated scope concept #15693)~~
~~Remove all the *.class container parameters that define the namespace of the classes of the services (ref removed all *.class parameters #14070)~~
...

DomCrawler

Add support for fallback hidden fields. (ref)
~~Cleaning the Crawler API. (ref)~~
...

Forms

IntegerType should be used for whole integers as the name suggests and not for floats. (ref)
NumberType should be used for floats (rendering as an input[type="number"]), and have a new option (for instance support_locale_strings) so that it renders as input[type="text"] and has the relevant attached NumberToLocalizedStringTransformer. (ref)
Remove duplicated HTML attributes. Right now, the attributes passed in the attr option are rendered both in the <form> tag and in the <div>/<table> tag of the form. (ref)
...

FrameworkBundle

~~Methods of the base Controller class should be protected instead of public (ref)~~
~~Removed unused logger from DelegatingLoader~~, see [FrameworkBundle] remove unused property in DelegatingLoader #6298
...

HttpFoundation

~~Remove the request service (ref)~~
Lazy initialization of Request headers. This can be a perfomance improvement for all requests which does not operate with request headers (almost all?) (ref)
~~Request->getRequestFormat() should only rely on the request attributes. (ref)~~
Deprecate session as a service (ref)
...

HttpKernel

~~Remove isClassInActiveBundle() method from Kernel and KernelInterface (ref)~~

Security

~~supportsClass and supportAttribute are actually never used in Symfony except by voters themselves. They should be removed from the VoterInterface. (ref)~~
A clear exception should be thrown if no voters voted on an attribute. So if you did a typo (e.g. CREETE instead of CREATE), you'd see a clear message, rather than nobody voting and access being granted/denied 100% of the time based on your voting strategy. (ref)
Update UserInterface and UserProviderInterface to change the name of the methods getUsername() and loadUserByUsername() because they are confusing. You can identify your users bu email for example, so hardcoding username doesn't look right (ref, ref)
~~Deprecate SecurityContext and move its code to the AuthorizationChecker and TokenStorage. (ref)~~
Remove the RoleInterface and the Role class in favor of using strings only for roles: [Security] RoleSecurityIdentity checks for instances of RoleInterface to allow custom Role implementation #8313 (comment)
...

Translation

Replace custom and hackish solutions (PR 4884, PR 5547) by the standard MessageFormatter PHP class. (ref)
...

Web Profiler

~~Remove the import/export feature of the Web Profiler. (ref) -> see [WebProfilerBundle] deprecated import/export commands #15709~~
...

The text was updated successfully, but these errors were encountered:

stof · 2014-08-23T10:58:38Z

It's not easy to generate Uris, asset Uris, etc. due to the infamous request scope

the issue is only about generating asset uris. there is no request scope involved when using the router

javiereguiluz · 2014-08-23T11:04:32Z

@stof updated the description of the issue. Thanks!

lyrixx · 2014-08-23T14:16:39Z

you miss:

javiereguiluz · 2014-08-23T14:21:32Z

@lyrixx you are right! But this is a WIP issue, so we still have to add tens (hundreds?) of issues. Anyway, I'm adding right now the issues that you proposed. Thanks!

weaverryan · 2014-08-23T14:26:23Z

@javiereguiluz Can you change the title to "Symfony 3.0 proposed backward incompatible changes"? That will help me understand immediately that we're not re-documenting the UPGRADE-3.0 file, but are keeping track of things we want to do for 3.0.

Thanks!

javiereguiluz · 2014-08-23T14:30:36Z

@weaverryan done! Excuse me for the confusion.

Koc · 2014-08-25T10:14:59Z

supportsClass and supportAttribute are actually never used in Symfony except by voters themselves. They should be removed from the VoterInterface.

What about moving checks to the Symfony side from voters?

stof · 2014-08-25T10:40:03Z

@Koc supportsClass and supportAttribute are not easy to use for a good implementation:

you are not always able to call supportsClass given that $object can be null (when voting for roles for instance)
supporting inheritance properly for a supportsClass implementation is tricky. It requires 2 conditions. See https://github.com/FriendsOfSymfony/FOSUserBundle/blob/094bea6f318fbb067db3ddf6d26a62af0bf13442/Security/UserProvider.php#L81 for instance. Doing the check in isGranted with the object itself allows to use an instanceof operator and being done with it.
supportAttribute is limited. Some voters may be able to support different attributes based on the object they receive
there can be more reasons to abstain.

We don't need these methods in the interface, and enforcing their usage would make implementing voters more complex IMO

linaori · 2014-08-26T08:49:28Z

As I made this PR, I find this name confusing: "Separate SecurityContext from the Security component. (ref)". Mainly because I have marked the SecurityContext as deprecated due to logic moving to the AuthorizationChecker and TokenStorage. It's not moving away from the component.

javiereguiluz · 2014-08-26T08:53:02Z

@iltar fixed! Thanks for noticing this error.

hacfi · 2014-09-06T16:55:26Z

I created a deprecation PR #11869 for removal of Kernel/KernelInterface::isClassInActiveBundle (HttpKernel).

Tobion · 2014-10-05T17:22:47Z

I removed #10645 from the list.

stof · 2014-10-08T12:12:19Z

I added the proposal of removing the Role and RoleInterface from the Security component which was suggested in #8313 (comment)

sebastianblum · 2014-10-08T15:05:19Z

I would suggest that we rename all event subscriber classes from Listener to Subscriber with 3.0

fabpot · 2014-10-08T15:10:10Z

@sebastianblum No, a subscriber class can also be used as a regular listener one. That's why they are named like this and that should not be changed.

linaori · 2014-10-08T15:13:14Z

Classes that connect to the event dispatcher should be suffixed with Listener.

I think this part of documentation should be updated in that case: http://symfony.com/doc/current/cookbook/bundles/best_practices.html#classes

Proposal:

Classes that connect to the event dispatcher should be suffixed with Listener or Subscriber.

Koc · 2014-10-18T08:16:40Z

ref #10832, #9071

Koc · 2015-04-22T07:55:04Z

ref #9233, #6036 (comment)

Tobion · 2015-09-07T12:47:58Z

I updated the description with current state.

fabpot · 2015-09-07T13:23:28Z

#15709 deprecates the profiler:import/export commands

Tobion · 2015-09-07T18:52:05Z

@fabpot there is still a "remove prototype scope (#12585 (comment))" todo item which would mean removing the "shared" flag on the DI again which was just added. Is it really wanted?

wouterj · 2015-09-07T19:09:25Z

@Tobion this was discussed shortly during last meeting: https://gist.github.com/Nicofuma/2f75343c73aa75577b52#file-symfony-metting-L34-L81

Tobion · 2015-09-07T20:47:40Z

I see. It seems people agreed that removing shared=false is not needed as it already exists and is documented (via prototype) and doesn't cause overhead. Factory use-cases also exist. So I'm removing that point from the list.

fabpot · 2015-09-09T21:20:56Z

shared should be kept.

…(fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] deprecated import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #11742 | License | MIT | Doc PR | n/a Commits ------- 943fec9 [HtppKernel] deprecated Profiler::import/export 17e00b9 [WebProfilerBundle] deprecated import/export commands

…commands (jakzal) This PR was merged into the 3.0-dev branch. Discussion ---------- [WebProfilerBundle][HttpKernel] removed import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | part of #11742 | License | MIT | Doc PR | n/a Follow up for #15709. Commits ------- c1d028e [HttpKernel] removed Profiler::import/export 1672a83 [WebProfilerBundle] removed import/export commands

stof · 2015-09-20T22:38:58Z

I added #15849 in the list. I already thought about this in the past (always in cases when I was reviewing PRs related to optimizing the component btw), but it looks like I never opened an issue to discuss it.

…ass methods (WouterJ) This PR was squashed before being merged into the 2.8 branch (closes #15151). Discussion ---------- [Security] Deprecated supportsAttribute and supportsClass methods These methods aren't used at all in a Symfony application and don't make sense to use in the application. They are only used internally in the voters. This means the voter interface can be made much easier. I'm not sure how we do these deprecations, should we remove the methods from the interface now already? Also, I don't think it's possible to trigger deprecation notices for the voter methods? | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | one of #11742 | License | MIT | Doc PR | - Abstract Voter --- There is one remaining question about the abstract voter. This currently has abstract `getSupportedAttributes()` and `getSupportedClass()` methods. One of the reasons to remove the methods for the interface was that these methods are not flexible. Does it make sense to deprecate these methods as well and replace them by an abstract `protected vote(array $attributes, $class)` method in the `AbstractVoter` (which is called from `AbstractVoter#vote()`) ? Commits ------- 6588708 [Security] Deprecated supportsAttribute and supportsClass methods

This PR was merged into the 2.8 branch. Discussion ---------- deprecated the Shell Console class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | one of #11742 | License | MIT | Doc PR | n/a Commits ------- 1c17928 deprecated the Shell Console class

javiereguiluz · 2015-11-25T13:50:31Z

Closing this issue because we're so close to Symfony 3 launch that it no longer makes sense to have this meta-issue.

dosten · 2015-12-20T03:12:19Z

@javiereguiluz Maybe we can create a new issue with the pending issues or rename this one to target 4.0

javiereguiluz · 2015-12-20T07:51:16Z

@dosten I think it would be better to create a new issue.

…formatter (aitboudad) This PR was merged into the 3.4 branch. Discussion ---------- [Translation] added support for adding custom message formatter | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | yes | | Tests pass? | yes | | Fixed tickets | #6009, #10152, one item in #11742, #11948 | | License | MIT | | Doc PR | ~ | Commits ------- 42183b0 [Translation] Support adding custom message formatter

…mmands (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] deprecated import/export commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of symfony#11742 | License | MIT | Doc PR | n/a Commits ------- 943fec9 [HtppKernel] deprecated Profiler::import/export 17e00b9 [WebProfilerBundle] deprecated import/export commands

javiereguiluz changed the title ~~Symfony 3.0 backward incompatible changes~~ Symfony 3.0 proposed backward incompatible changes Aug 23, 2014

fabpot mentioned this issue Aug 26, 2014

Shell and Doctrine #11750

Closed

stof added this to the 3.0 milestone Sep 20, 2014

stof added the BC Break label Sep 20, 2014

guilhermeblanco mentioned this issue Sep 27, 2014

[DX][Translation][3.0] Adding support for intl message formatter and decoupling default formatter #12060

Closed

stof mentioned this issue Oct 8, 2014

[DX] Fix the documentation about the Symfony security symfony/symfony-docs#4158

Closed

3 tasks

Tobion mentioned this issue Oct 9, 2014

[Security] Adding __toString() method to Role class #10179

Closed

xabbuh mentioned this issue Nov 3, 2014

[3.0] [Form] Remove $data arguments from FormFactory #9175

Closed

drealecs mentioned this issue Dec 4, 2014

[SURVEY] Users of PHP-DI 4: please give feedback on the config syntax! PHP-DI/PHP-DI#206

Closed

javiereguiluz mentioned this issue Dec 23, 2014

[Console] Define isVerbose(), etc. methods in OutputInterface #13086

Closed

xelaris mentioned this issue Dec 29, 2014

Core User class returning roles as strings instead of Role objects #13037

Closed

fabpot removed the BC Break label Feb 11, 2015

dbu mentioned this issue Mar 10, 2015

[Session] SessionInterface should have a destroy() method. Currently there is no way to simply destroy a session #12375

Closed

aitboudad mentioned this issue Jun 22, 2015

[Translator] Adding support for intl message formatter and decoupling default formatter. #15068

Closed

wouterj mentioned this issue Jun 30, 2015

[Security] Deprecated supportsAttribute and supportsClass methods #15151

Closed

albertboada mentioned this issue Aug 14, 2015

[Acceptance] [InnerBrowser] Sending unchecked checkboxes Codeception/Codeception#2275

Closed

fabpot mentioned this issue Sep 7, 2015

[WebProfilerBundle] deprecated import/export commands #15709

Merged

jakzal mentioned this issue Sep 15, 2015

[WebProfilerBundle][HttpKernel] removed import/export commands #15801

Merged

Tobion mentioned this issue Sep 18, 2015

Fix potential access to undefined index #15825

Merged

fabpot mentioned this issue Sep 25, 2015

deprecated the Shell Console class #15892

Merged

ogizanagi mentioned this issue Oct 5, 2015

[FrameworkBundle] [Routing] DelegatingLoader: remove unused logger #16117

Closed

javiereguiluz closed this as completed Nov 25, 2015

aitboudad mentioned this issue Mar 25, 2016

[Translation] added support for adding custom message formatter #18314

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symfony 3.0 proposed backward incompatible changes #11742

Symfony 3.0 proposed backward incompatible changes #11742

javiereguiluz commented Aug 23, 2014

stof commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

lyrixx commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

weaverryan commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

Koc commented Aug 25, 2014

stof commented Aug 25, 2014

linaori commented Aug 26, 2014

javiereguiluz commented Aug 26, 2014

hacfi commented Sep 6, 2014

Tobion commented Oct 5, 2014

stof commented Oct 8, 2014

sebastianblum commented Oct 8, 2014

fabpot commented Oct 8, 2014

linaori commented Oct 8, 2014

Koc commented Oct 18, 2014

Koc commented Apr 22, 2015

Tobion commented Sep 7, 2015

fabpot commented Sep 7, 2015

Tobion commented Sep 7, 2015

wouterj commented Sep 7, 2015

Tobion commented Sep 7, 2015

fabpot commented Sep 9, 2015

stof commented Sep 20, 2015

javiereguiluz commented Nov 25, 2015

dosten commented Dec 20, 2015

javiereguiluz commented Dec 20, 2015

Symfony 3.0 proposed backward incompatible changes #11742

Symfony 3.0 proposed backward incompatible changes #11742

Comments

javiereguiluz commented Aug 23, 2014

Commands

Console

DependencyInjection

DomCrawler

Forms

FrameworkBundle

HttpFoundation

HttpKernel

Security

Translation

Web Profiler

stof commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

lyrixx commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

weaverryan commented Aug 23, 2014

javiereguiluz commented Aug 23, 2014

Koc commented Aug 25, 2014

stof commented Aug 25, 2014

linaori commented Aug 26, 2014

javiereguiluz commented Aug 26, 2014

hacfi commented Sep 6, 2014

Tobion commented Oct 5, 2014

stof commented Oct 8, 2014

sebastianblum commented Oct 8, 2014

fabpot commented Oct 8, 2014

linaori commented Oct 8, 2014

Koc commented Oct 18, 2014

Koc commented Apr 22, 2015

Tobion commented Sep 7, 2015

fabpot commented Sep 7, 2015

Tobion commented Sep 7, 2015

wouterj commented Sep 7, 2015

Tobion commented Sep 7, 2015

fabpot commented Sep 9, 2015

stof commented Sep 20, 2015

javiereguiluz commented Nov 25, 2015

dosten commented Dec 20, 2015

javiereguiluz commented Dec 20, 2015