[Form] Add "range" type #11979
Labels
Feature
Form
Good first issue
Ideal for your first contribution! (some Symfony experience may be required)
Comments
|
Does this really deserve its own dedicated form type, or could it be an option in the integer and number types. The range control is very similar in terms of functionality and behaviour as the number control. It's just really the UI that's different. Likewise, is it for implementing the other HTML5 inputs into Symfony Core as their own field types? |
|
+1 for the option insted of the dedicated form type as @LewisW says. I'm on the hackaton in Madrid and gonna try to do this. @javiereguiluz @weaverryan |
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
|
sorry about the lot of references. i had to do some rebases and push again. |
crevillo
added a commit
to crevillo/symfony
that referenced
this issue
Nov 29, 2014
|
👍 |
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
… passing attributes to view, added validation, added missing 'step' option
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
…orm field and validating options
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
Kryniol
pushed a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
[Form] Add range type symfony#11979 - registered RangeType in CoreExtension [Form] Add range type symfony#11979 - added tests for rendering the form field and validating options [Form] Add range type symfony#11979 - added copyright lines in RangeTypeTest class [Form] Add range type symfony#11979 - minor formatting fixes, added author block
Kryniol
pushed a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 9, 2015
[Form] Add range type symfony#11979 - registered RangeType in CoreExtension [Form] Add range type symfony#11979 - added tests for rendering the form field and validating options [Form] Add range type symfony#11979 - added copyright lines in RangeTypeTest class [Form] Add range type symfony#11979 - minor formatting fixes, added author block
Kryniol
pushed a commit
to Kryniol/symfony
that referenced
this issue
Apr 14, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 14, 2015
[Form] Add range type symfony#11979 - registered RangeType in CoreExtension [Form] Add range type symfony#11979 - added tests for rendering the form field and validating options [Form] Add range type symfony#11979 - added copyright lines in RangeTypeTest class [Form] Add range type symfony#11979 - minor formatting fixes, added author block
Kryniol
pushed a commit
to Kryniol/symfony
that referenced
this issue
Apr 14, 2015
Kryniol
added a commit
to Kryniol/symfony
that referenced
this issue
Apr 14, 2015
[Form] Add range type symfony#11979 - registered RangeType in CoreExtension [Form] Add range type symfony#11979 - added tests for rendering the form field and validating options [Form] Add range type symfony#11979 - added copyright lines in RangeTypeTest class [Form] Add range type symfony#11979 - minor formatting fixes, added author block
webmozart
added a commit
that referenced
this issue
Jun 17, 2015
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #12067). Discussion ---------- [Form] Added the 'range' FormType | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11979 | License | MIT | Doc PR | Implemented the "range" FormType. Commits ------- b52e197 [Form] Added the 'range' FormType
|
Fixed in #12067. |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this issue
Jul 16, 2015
This PR was merged into the 2.8 branch. Discussion ---------- HTML5 range documentation Hi, | Q | A | ------------- | --- | Doc fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | [#5439] | Code PR | [12607] | License | MIT I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 . Need some help on moving for I am really new to the documentation. The current issues I feel is whether we need to add Basic usage or is that only reference ? I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing. I have looked into other types also and almost all are some what similar. Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it . Thank you. Commits ------- 2863079 Fix moving the mapped down as per @xabbuh abf3e8e Fix the rendering issue 3c6ff76 Fix issues reported by @snoek09 . Thank you. a2c3f21 Make the necessary changes mentioned by @xabbuh and add example for form d4d1f12 Starting with range documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is missing support for "range" html element: "Could not load type "range""
http://www.w3schools.com/html/tryit.asp?filename=tryhtml5_input_type_range
http://caniuse.com/#feat=input-range
The text was updated successfully, but these errors were encountered: