[TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment #13141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4177ee9 to
e56f5e6
Compare
…the Twig engine to the Twig environment
e56f5e6 to
91b24e8
Compare
fabpot
added a commit
that referenced
this pull request
Dec 29, 2014
…ategy from the Twig engine to the Twig environment (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11773 | License | MIT | Doc PR | n/a The default escaping strategy was set on the Twig Engine and not the Twig Environment. That's a problem under some circumstances (like what #11773 describes), but it's also much better to set everything on the Twig Environment directly. Commits ------- 91b24e8 [TwigBundle] Moved the setting of the default escaping strategy from the Twig engine to the Twig environment
|
|
||
| if ('txt' === $format) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
What about supporting .css.twig too ? Twig supports the css escaping context too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default escaping strategy was set on the Twig Engine and not the Twig Environment. That's a problem under some circumstances (like what #11773 describes), but it's also much better to set everything on the Twig Environment directly.