-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel] [WebProfilerBundle] add status code to search form #15106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
oktapodia
wants to merge
90
commits into
symfony:2.7
from
oktapodia:webprofiler-add-status-code-to-search-form
Closed
[HttpKernel] [WebProfilerBundle] add status code to search form #15106
oktapodia
wants to merge
90
commits into
symfony:2.7
from
oktapodia:webprofiler-add-status-code-to-search-form
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5503804.
* 2.7: [HttpKernel] fixed a regression when no exception listeners are registered renamed some confusing tests propel/propel1 is now useless bumped Symfony version to 2.7.0 updated VERSION for 2.7.0-BETA1 updated CHANGELOG for 2.7.0-BETA1 [2.3] Fix @link annotations [2.7] For @link annotations [2.6] Fix @link annotations [2.7][Console] Count the array instead of [Config][cache factory] check type of callback argument. Fix javascript [2.3][Translation] test refresh cache when resources File change. Added deprecation message and original color back [Translator] Cache does not take fallback locales into consideration
…ber option. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][Server Command] add address port number option. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ This allow running server without repeating `127.0.0.1` each time, in the most of case we only change the port number. * Before ``` app/console server:start 127.0.0.1:8080 ``` * After ``` app/console server:start -p 8080 ``` Commits ------- fbe1a43 [FrameworkBundle][Server Command] add address port number option.
This PR was merged into the 2.8 branch. Discussion ---------- [Translation] added FileLoader. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 3694e5e [Translation] added FileLoader.
This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Added support for SplFileInfo | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Before: ``` SplFileInfo {#3} ``` After: ``` SplFileInfo {#3 path: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures" filename: "grisou.jpg" basename: "grisou.jpg" pathname: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg" extension: "jpg" realPath: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg" aTime: 2015-04-20 23:21:15 mTime: 2014-08-17 15:37:36 cTime: 2015-04-20 23:09:51 inode: 12197643 size: 966553 perms: 0100750 owner: 1000 group: 1000 type: "file" writable: true readable: true executable: true file: true dir: false link: false } ``` For a link: ``` SplFileInfo {#3 path: "" filename: "link" basename: "link" pathname: "link" extension: "" realPath: "/home/greg/dev/github.com/symfony/var-dumper/composer.json" aTime: 2015-04-20 23:39:15 mTime: 2015-04-20 23:39:15 cTime: 2015-04-20 23:39:15 inode: 11272232 size: 967 perms: 0100644 owner: 1000 group: 1000 type: "link" writable: true readable: true executable: false file: true dir: false link: true linkTarget: "composer.json" } ``` For a remote file: ``` SplFileInfo {#3 path: "http://google.com" filename: "foobar.php" basename: "foobar.php" pathname: "http://google.com/foobar.php" extension: "php" realPath: false writable: false readable: false executable: false file: false dir: false link: false } ``` For a CSV: ``` SplFileObject {#3 path: "" filename: "test.csv" basename: "test.csv" pathname: "test.csv" extension: "csv" realPath: "/home/greg/dev/github.com/symfony/var-dumper/test.csv" aTime: 2015-04-21 12:55:07 mTime: 2015-04-21 12:55:07 cTime: 2015-04-21 12:55:07 inode: 11272237 size: 0 perms: 0100644 owner: 1000 group: 1000 type: "file" writable: true readable: true executable: false file: true dir: false link: false csvControl: array:2 [ 0 => "," 1 => """ ] flags: SKIP_EMPTY|READ_CSV maxLineLen: 0 fstat: array:7 [ "dev" => 64513 "ino" => 11272237 "nlink" => 1 "rdev" => 0 "blksize" => 4096 "blocks" => 0 "…" => "…20" ] eof: false key: 0 } Commits ------- e75c233 [VarDumper] Added support for SplFileObject eb50b13 [VarDumper] Added support for SplFileInfo
…ssible (lyrixx) This PR was merged into the 2.8 branch. Discussion ---------- [Console] Bind the closure (code) to the Command if possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ This allow this kind of code: ```php #!/usr/bin/env php <?php require __DIR__.'/vendor/autoload.php'; use Symfony\Component\Console\Application; use Symfony\Component\Console\Command\Command; use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Output\OutputInterface; $application = new Application(); $application->add((new Command('process'))) ->setDescription('Play all other commands') ->setCode(function (InputInterface $input, OutputInterface $output) use ($application) { $application = $this->getApplication(); $help = $application->find('help'); $output->writeln($help->getHelp()); }) ; $application->run(); ``` Commits ------- ff4424a [Console] Bind the closure (code) to the Command if possible
…icolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Allow preserving a subset of cut arrays | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 208ca94 [VarDumper] Allow preserving a subset of cut arrays
* 2.7: (40 commits) [Debug] Fix ClassNotFoundFatalErrorHandler candidates lookups [2.6][Translator] Extend, refactor and simplify Translator tests. Update DebugClassLoader.php inject asset packages in assets helper service [travis] Do not exclude legacy tests on 2.7 [HttpFoundation] remove getExtension method [2.6][Translation] fix legacy tests. [Form] Removed remaining deprecation notices in the test suite [Form] Moved deprecation notice triggers to file level [Debug] Map PHP errors to LogLevel::CRITICAL [Routing][DependencyInjection] Support .yaml extension in YAML loaders [DX] improve file loader error for router/other resources in bundle [FrameworkBundle] Initialize translator with the default locale. [FrameworkBundle] Fix Routing\DelegatingLoader resiliency to fatal errors [2.7][Translation] remove duplicate code for loading catalogue. [2.6][Translation] remove duplicate code for loading catalogue. [HttpKernel] Cleanup ExceptionListener CS fixes [DependencyInjection] Show better error when the Yaml component is not installed [2.3] SCA for Components - reference mismatches ...
* 2.7: [Debug] Fix deprecated use of DebugClassLoader Revert "[HttpKernel] Throw a LogicException when kernel.exception does not led to a Response" [Validator] Fixed Choice when an empty array is used in the "choices" option
* 2.7: Fix test
* 2.7: [FrameworkBundle] Fix test related to PSR-4
…t (nicolasdewez) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #14473). Discussion ---------- [DX] Minor improvement for the translation:debug output | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13874 Commits ------- b941bd3 Changed output for translation:debug command
…lation command #14237 (sgehrig) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #14320). Discussion ---------- [Translation] added an --all option to the debug:translation command #14237 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14237 | License | MIT | Doc PR | - - [ ] submit changes to the documentation This PR adds an `--all` option the `debug:translation` command to enable debugging translations in all registered bundles *AND* the app directory. Commits ------- 0e7fe79 added the --all option to the debug:translation command
…dispatcher command
…logue. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [Translator] deprecate getMessages in favor of getCatalogue. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | #14529 | Tests pass? | yes | License | MIT Commits ------- 2869a32 [Translator] deprecate getMessages in favor of getCatalogue.
…he debug:event-dispatcher command (Seldaek) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][EventDispatcher] Add priorities to the debug:event-dispatcher command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | TODO I find it helps to figure out which priority is needed to override another event listener without digging in the sources. Commits ------- 952929c [FrameworkBundle][EventDispatcher] Add priorities to the debug:event-dispatcher command
… translation loading paths (Seldaek) This PR was squashed before being merged into the 2.8 branch (closes #14561). Discussion ---------- [FrameworkBundle][DX] Add option to specify additional translation loading paths | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #971 | License | MIT | Doc PR | TODO Thanks to this PR, next time I want to just do: ``` translator: fallback: "%locale%" paths: ['%kernel.root_dir%/../vendor/internal/package/translations'] ``` I will be able to, and won't have to dig in docs, start building a translation loader before I realize it's not what I want, dig in the framework ext, and then have to write a compiler pass to inject my file to the translator resource paths. Commits ------- bba0a25 [FrameworkBundle][DX] Add option to specify additional translation loading paths
This PR was merged into the 2.8 branch. Discussion ---------- [Profiler][Translation] added filter. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT  Commits ------- 65f9291 [Profiler][Translation] added filter.
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #12067). Discussion ---------- [Form] Added the 'range' FormType | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11979 | License | MIT | Doc PR | Implemented the "range" FormType. Commits ------- b52e197 [Form] Added the 'range' FormType
…(kgilden) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #12314). Discussion ---------- [Form] Add "prototype_data" option to collection type | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5095 | License | MIT | Doc PR | symfony/symfony-docs#4367 Makes it possible to have default data for collection prototypes. Commits ------- 80b0a80 [Form] Add "prototype_data" option to collection type
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Deprecated "cascade_validation" | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #11268 (requires explicit work though) | License | MIT | Doc PR | TODO This is #12237 rebased on 2.8. The "cascade_validation" option was designed for a 1% use case and comparatively used way too often when the `Valid` constraint should have been used instead. Also, there seem to be bugs with that option (#5204). The option is now deprecated. When using the 2.5 Validator API, you can set the "constraints" option of the respective child to a `Valid` constraint instead. Alternatively, set the constraint in the model (as most people hopefully do). Commits ------- 6c554c6 [Form] Deprecated "cascade_validation"
…Submit to ResizeFormListener (BruceWouaigne) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #13851). Discussion ---------- [Form] [EventListener] fixed sending non array data on preSubmit to ResizeFormListener | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13804 | License | MIT | Doc PR | - Commits ------- 74d794b [Form] [EventListener] fixed sending non array data on submit to ResizeListener
* 2.7: (36 commits) [DoctrineBridge] Bypass the db when no valid identifier is provided in ORMQueryBuilderLoader [Serializer] Fixed typo in comment [Form] Fixed: Filter non-integers when selecting entities by int ID Fix merge Fix merge Add test for HHVM FatalErrors [2.6][Debug] Fix fatal-errors handling on HHVM [Debug] Fix log level of stacked errors [VarDumper] Fix uninitialized id in HtmlDumper Fixed fluent interface [Console] Fix tests on Windows [2.7] Fix unsilenced deprecation notices [2.3][Debug] Fix fatal-errors handling on HHVM [Debug] fix debug class loader case test on windows Standardize the name of the exception variables [Debug+VarDumper] Fix handling of PHP7 exception/error model Do not trigger deprecation error in ResolveParameterPlaceHoldersPass [2.3] Static Code Analysis for Components Added a small Upgrade note regarding security.context added missing deprecation in CHANGELOG ... Conflicts: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig src/Symfony/Component/HttpKernel/Kernel.php
* 2.7: [FrameworkBundle] Reuse PropertyAccessor service for ObjectNormalizer [VarDumper] Fix dump output for better readability [PhpUnitBridge] Enforce @-silencing of deprecation notices according to new policy
…StringUtil (issei-m) This PR was squashed before being merged into the 2.8 branch (closes #14660). Discussion ---------- [Form] moved data trimming logic of TrimListener into StringUtil | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I introduced this PR at #14146, but I didn't make it on time for 2.7 feature freeze. So I'm opening the new PR for 2.8. Following is my first introduction: > In the small job which needs not to build a form (e.g. just process a value gotten from Request), I want to reuse the trim logic. @dosten @Tobion @xabbuh @stof @webmozart Thanks for all your feedback. I have fixed all issues mentioned on #14146. Please re-consider it. Commits ------- f42c777 [Form] moved data trimming logic of TrimListener into StringUtil
This PR was merged into the 2.8 branch. Discussion ---------- [Console][Table] allow multiple render() calls. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT This is a cherry-pick of #14983. Commits ------- b93bcc1 Fixed colspan issues with multiple render() calls
…ion for validator mapping (jakzal) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Add a doctrine cache service definition for validator mapping | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#5409 Following #12975, this PR only registers a new service so it's possible to use the new doctrine based cache implementation instead of the deprecated one. To use it, the end user would need to configure it in his `config.yml`: ```yaml framework: validation: cache: validator.mapping.cache.doctrine.apc ``` In 3.0 we'll be able to replace the deprecated definition by aliasing `validator.mapping.cache.apc` to `validator.mapping.cache.doctrine.apc`. I thought of automatic wrapping of services which implement doctrine interface, but decided it would be too magic. I'm not convinced if APC is a good default anymore and hope for some discussion. I've used it as it's also used in serializer, and probably translation (see #13986). Since there's a built in opcache in more recent PHP versions, and apcu doesn't seem to be stable, there are better choices. Perhaps a better default would be a filesystem cache (not better performing, but it works anywhere). Commits ------- 0642911 [FrameworkBundle] Add a doctrine cache service definition for validator mapping
…e, E_USER_ERROR);`
This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] Deprecate scope concept | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | License | MIT This PR mark as deprecated the concept of scopes in the DI container. See #10557 (comment). Also adds a new `shared` flag to the service definitions in replacement of the `prototype` scope. Commits ------- 6c4a676 Add "shared" flag and deprecate scopes concept
…t (WouterJ) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] Make service not shared when prototype scope is set | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Deprecating the scopes was introducing a BC break in Symfony 2.8 when using the prototype scope. As `$shared` wasn't updated if the scope was set to `prototype`, people will always get an error because of [the `CheckDefinitionValidityPass`](https://github.com/symfony/DependencyInjection/blob/04d5d925a987f35854f51b1c468c0ca81e1d61b9/Compiler/CheckDefinitionValidityPass.php#L54-L57). Commits ------- b7030cc Make service not shared when prototype scope is set
…trigger_error($e, E_USER_ERROR);` (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Allow throwing from __toString() with `return trigger_error($e, E_USER_ERROR);` | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f360758 [Debug] Allow throwing from __toString() with `return trigger_error($e, E_USER_ERROR);`
Thanks for the PR. But new features must be based on 2.8 now. |
Thanks for your answer, this is the new PR #15111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, in the web profiler, you can filter by HTTP status codes.
Before filter

After filter
