Removed the "Delete profiles" action from the web profiler sidebar #15939
Conversation
javiereguiluz
commented
Sep 27, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #15819 |
| License | MIT |
| Doc PR | - |
|
LGTM. Do we add a command for the CLI to purge the profiles? Or is |
|
My opinion:
|
|
@javiereguiluz Let's do it. Can you create a PR that deprecates all storages but the filesystem one? I think we can still keep the interface just in case. |
|
Done in #15944. |
|
👍 |
| @@ -486,32 +486,15 @@ tr.status-warning td { | |||
| padding-bottom: 99999px; {# needed for 'same-height columns' trick #} | |||
| width: 220px; | |||
| } | |||
| #sidebar a { | |||
| color: #ADD8E6; | |||
| } | |||
There was a problem hiding this comment.
Don't we still need this for the logout link?
There was a problem hiding this comment.
Nope. In the toolbar we use .sf-toolbar-block .sf-toolbar-info-piece a. I've tried to make the toolbar and the profiler as independent as possible.
|
Thank you @javiereguiluz. |
…iler sidebar (javiereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- Removed the "Delete profiles" action from the web profiler sidebar | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #15819 | License | MIT | Doc PR | - Commits ------- 8c47eb9 Removed the "Delete profiles" action from the web profiler sidebar