Skip to content

[3.0] Added getBlockPrefix to FormTypeInterface #16724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 28, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@wouterj
Copy link
Member Author

wouterj commented Nov 28, 2015

Failures seem unrelated to this PR

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2015

@wouterj Can you rebase on the latest master branch? That should make the test pass.

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2015

👍 anyway as the failure is not related to these changes

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Nov 28, 2015

Thank you @wouterj.

@fabpot fabpot merged commit d834cd3 into symfony:master Nov 28, 2015
fabpot added a commit that referenced this pull request Nov 28, 2015
This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] Added getBlockPrefix to FormTypeInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d834cd3 Added getBlockPrefix to FormTypeInterface
@wouterj wouterj deleted the form_type_interface branch November 28, 2015 16:00
@webmozart
Copy link
Contributor

Here's the follow-up: #16749

Tobion added a commit that referenced this pull request Nov 29, 2015
…ce (webmozart)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] Added getBlockPrefix() to ResolvedFormTypeInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is the follow-up PR to #16724.

If you call `$form->getConfig()->getType()`, all the methods of FormType should be usable. In that sense, ResolvedFormType is the developer-facing version of FormType.

It is true that the same could be achieved with `getInnerType()`, but that method should be used in edge cases only as it clutters the code and makes it confusing to read:

```php
$blockPrefix = $form->getConfig()->getType()->getInnerType()->getBlockPrefix();
```

Commits
-------

7e89345 [Form] Added getBlockPrefix() to ResolvedFormTypeInterface
@fabpot fabpot mentioned this pull request Nov 30, 2015
stof added a commit that referenced this pull request Dec 5, 2015
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #16752).

Discussion
----------

[Form] document changes to form type interfaces

| Q             | A
| ------------- | ---
| Fixed tickets | #13407, #16024, #16724, #16749
| License       | MIT

Commits
-------

b297a0c [Form] document changes to form type interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants