The widget choice_widget_collapsed also need to be modified to remove the form-control class.
Maybe I was unclear about this in my comment on the ticket.

@satanasdiabolo I've removed the form-control class from <select> elements too, as Bootstrap does. But beware that this change can severely change the look of your application. This is what happened to one of my applications:

Before

After

@javiereguiluz You shouldn't remove it from the select. In the issue I gave the list of "input" types that were intended to be used with the "form-control" class but I forgot to cite "select" and "textarea" as they seemed "off topic", I might have been wrong.

// Common form controls
//
// Shared size and type resets for form controls. Apply `.form-control` to any
// of the following form controls:
//
// select
// textarea
// input[type="text"]
// input[type="password"]
// input[type="datetime"]
// input[type="datetime-local"]
// input[type="date"]
// input[type="month"]
// input[type="time"]
// input[type="week"]
// input[type="number"]
// input[type="email"]
// input[type="url"]
// input[type="search"]
// input[type="tel"]
// input[type="color"]

.form-control {

@michaelPf85 thanks. I've reverted the last change.

I don't understand the failed tests. They refer to the vendor/ dir inside the Twig Bridge:

/home/travis/build/symfony/symfony/src/Symfony/Bridge/Twig/vendor/symfony/form/Tests/AbstractLayoutTest.php:84
/home/travis/build/symfony/symfony/src/Symfony/Bridge/Twig/vendor/symfony/form/Tests/AbstractLayoutTest.php:106
/home/travis/build/symfony/symfony/src/Symfony/Bridge/Twig/vendor/symfony/form/Tests/AbstractBootstrap3LayoutTest.php:697

Can we ignore these fails or should we do something else? Thanks!

It seems like 02b06e5 is not committed in those failing tests, see this line [@class="form-control"] is still there.

@javiereguiluz Can you finish this one and fix the tests?

I've got the same problem in my tests of #17609, could something go wrong with travis ?

Looks like you need to bump requirements of the Form component in the TwigBridge or make it flexible enough to provide output that satisfied all versions.

@xabbuh thanks for the hint. Do you have any proposal for the new requirements to use? Thanks!

@javiereguiluz I think changing the version constraint from ~2.7,>=2.7.8 to ~2.7,>=2.7.10 should make the low dependency tests pass.

@xabbuh thank you! I've changed it. Let's see if tests go green again.

@javiereguiluz sorry, I forgot about 2.8, please try ~2.7.10|~2.8.3

Tests are still red.

@fabpot This failure is expected as the subtree split of the Form component doesn't know anything about the updated tests here (only the deps=high tests for the TwigBridge are failing).

👍

Status: Reviewed

Thank you @javiereguiluz.