[WIP] [2.8] [Form] fix FQCN in tests added by #17760 #17759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Feb 11, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
- Update tests from [2.7] [Form] fix choice value "false" in ChoiceType #17760
- Wait for [2.7] [Form] fix choice value "false" in ChoiceType #17760 to be merged in 2.8
|
Isn't this the same as #17760? |
|
What if someone uses |
|
@iltar it returns an empty string as expected. But it was the same for |
|
Status : Needs Work |
3 tasks
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
…ude) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [Form] fix choice value "false" in ChoiceType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17292, #14712, #17789 | License | MIT | Doc PR | - - [x] Add tests for choices with `boolean` and `null` values, and with a placeholder - [x] Fix FQCN in 2.8 tests, see #17759 - [x] Remove `choices_as_values` in 3.0 tests, see #17886 Commits ------- 8f918e5 [Form] refactor `RadioListMapper::mapDataToForm()` 3eac469 [Form] fix choice value "false" in ChoiceType
|
#17760 has been merged. |
|
Is this one still needed? |
|
No let's close. |
|
But it would be more consistent with other tests. I missed the ping this should have been merged before #17886 :( Will there be some conflicts ? I let you decide to close then. |
|
I've rebased, it's up to you. |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
…ahDude) This PR was merged into the 2.8 branch. Discussion ---------- [WIP] [2.8] [Form] fix FQCN in tests added by #17760 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | n/a | License | MIT | Doc PR | - - [x] Update tests from #17760 - [x] Wait for #17760 to be merged in 2.8 Commits ------- acdd7db [Form] fix tests added by #17760 with FQCN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.