[WIP] [3.0] [Form] fix tests added by #17760 by removing choices_as_values
#17886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Feb 22, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
- Wait for [2.7] [Form] fix choice value "false" in ChoiceType #17760 being merged in 3.0
3 tasks
| { | ||
| $view = $this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType', null, array( | ||
| 'choices' => $this->scalarChoices, | ||
| ))->createView(); |
There was a problem hiding this comment.
If you're merging this into 3.0, you can use ChoiceType::class, not sure if that's preferable though.
There was a problem hiding this comment.
@iltar, I know, I even proposed to use constants in core type tests (see #17699 (comment)) as of 2.8 but this is actually to be consistent with other tests ;)
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
…ude) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [Form] fix choice value "false" in ChoiceType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17292, #14712, #17789 | License | MIT | Doc PR | - - [x] Add tests for choices with `boolean` and `null` values, and with a placeholder - [x] Fix FQCN in 2.8 tests, see #17759 - [x] Remove `choices_as_values` in 3.0 tests, see #17886 Commits ------- 8f918e5 [Form] refactor `RadioListMapper::mapDataToForm()` 3eac469 [Form] fix choice value "false" in ChoiceType
|
#17760 merged |
6d3d86d to
1850da1
Compare
|
Should be ok. Let me know :) |
|
Not yet :( |
1850da1 to
e7234d8
Compare
|
Ok now I'm waiting for the green lights. |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Feb 26, 2016
… `choices_as_values` (HeahDude) This PR was squashed before being merged into the 3.0 branch (closes #17886). Discussion ---------- [WIP] [3.0] [Form] fix tests added by #17760 by removing `choices_as_values` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | n/a | License | MIT | Doc PR | - - [x] Wait for #17760 being merged in 3.0 Commits ------- 03a7705 [WIP] [3.0] [Form] fix tests added by #17760 by removing
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.