Remove deprecated container injections and compiler passes #22749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f679e43 to
8b0ccf6
Compare
|
rebase needed to see tests green |
|
done, thanks |
stof
requested changes
May 18, 2017
| @@ -57,18 +56,6 @@ class Translator extends BaseTranslator implements WarmableInterface | |||
| */ | |||
| public function __construct(ContainerInterface $container, MessageSelector $selector, $defaultLocale = null, array $loaderIds = array(), array $options = array()) | |||
| { | |||
| // BC 3.x, to be removed in 4.0 along with the $defaultLocale default value | |||
There was a problem hiding this comment.
you forgot to remove the default value
|
missing CHANGELOG updates in components (please check any your other PRs also if any) |
3b54859 to
c785d51
Compare
|
CHANGELOG entries added |
42c7aec to
455b6a0
Compare
| @@ -55,20 +54,8 @@ class Translator extends BaseTranslator implements WarmableInterface | |||
| * | |||
| * @throws InvalidArgumentException | |||
| */ | |||
| public function __construct(ContainerInterface $container, MessageSelector $selector, $defaultLocale = null, array $loaderIds = array(), array $options = array()) | |||
| public function __construct(ContainerInterface $container, MessageSelector $selector, $defaultLocale, array $loaderIds = array(), array $options = array()) | |||
There was a problem hiding this comment.
it looks like the docblock is not up to date - and we could add a "string" type hint meanwhile here
| * The default `type` option of the `framework.workflows.*` configuration entries is `state_machine` | ||
| * [BC BREAK] removed `AddConsoleCommandPass`, `AddConstraintValidatorsPass`, |
There was a problem hiding this comment.
i'm not sore we need all these bc break prefixes, I'd remove them
|
@nicolas-grekas comments addressed |
|
@chalasr would you mind opening a PR to fix that doc block in 3.3 (I guess)? |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…sses (chalasr) This PR was merged into the 4.0-dev branch. Discussion ---------- Remove deprecated container injections and compiler passes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~~#21451 #21625 #21284 #22010~~ #22805 | License | MIT | Doc PR | n/a Commits ------- 16a2fcf Remove deprecated container injections and compiler passes
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…halasr) This PR was merged into the 3.3 branch. Discussion ---------- Add missing doc param & deprecation changelog entries | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22749 (comment) | License | MIT | Doc PR | n/a Commits ------- 7b14d4f Add missing doc param & deprecation changelog entries
nicolas-grekas
added a commit
that referenced
this pull request
May 24, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] Remove deprecated code | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Remove deprecated code in the FrameworkBundle (except compiler passes and stuff already removed by #22749): * Removed `cache:clear` warmup part along with the `--no-optional-warmers` option. * Removed core form types services registration when unnecessary * Removed `framework.serializer.cache` option and `serializer.mapping.cache.apc`, `serializer.mapping.cache.doctrine.apc` services * Removed `ConstraintValidatorFactory::$validators` and `ConstraintValidatorFactory::$container` protected properties * Removed class parameters related to routing * Removed absolute template paths support in the template name parser Commits ------- 531156e [FrameworkBundle] Remove deprecated code
Merged
xabbuh
added a commit
that referenced
this pull request
Jan 1, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2018
* 4.0: (23 commits) Clean up Update return type in docblock. PHP CS Fixer: no need to exclude xml and yml files PHP CS Fixer: no need to exclude json file [#22749] fix version in changelog Update LICENSE year... forever fixed some deprecation messages fixed CS Fixes for Oracle in PdoSessionHandler fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages Remove dead code [TwigBundle/Brige] catch missing requirements to throw meaningful exceptions [DI] fix CS [HttpKernel] Call Response->setPrivate() instead of sending raw header() when session is started [FrameworkBundle] Make cache:clear "atomic" and consistent with cache:warmup Suggest to write an implementation if the interface cannot be autowired [Debug] Skip DebugClassLoader checks for already parsed files ...
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
* 4.0: (23 commits) Clean up Update return type in docblock. PHP CS Fixer: no need to exclude xml and yml files PHP CS Fixer: no need to exclude json file [symfony#22749] fix version in changelog Update LICENSE year... forever fixed some deprecation messages fixed CS Fixes for Oracle in PdoSessionHandler fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages Remove dead code [TwigBundle/Brige] catch missing requirements to throw meaningful exceptions [DI] fix CS [HttpKernel] Call Response->setPrivate() instead of sending raw header() when session is started [FrameworkBundle] Make cache:clear "atomic" and consistent with cache:warmup Suggest to write an implementation if the interface cannot be autowired [Debug] Skip DebugClassLoader checks for already parsed files ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21451 #21625 #21284 #22010#22805