[Translation] Adding the ability do dump <notes> in xliff2.0 #23890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRbt
reviewed
Aug 16, 2017
| $notesElement = $dom->createElement('notes'); | ||
| foreach ($metadata['notes'] as $note) { | ||
| $n = $dom->createElement('note'); | ||
| $n->appendChild($dom->createTextNode(isset($note['content']) ? $note['content'] : '')); |
There was a problem hiding this comment.
May we use $note['content'] ?? '' instead of isset($note['content']) ? $note['content'] : '' ?
There was a problem hiding this comment.
Thank you for the review.
This is for branch 3.4. We still support PHP5 in that branch. I actually just did: e12c555
nicolas-grekas
approved these changes
Aug 16, 2017
|
Thank you @Nyholm. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2017
…iff2.0 (Nyholm) This PR was squashed before being merged into the 3.4 branch (closes #23890). Discussion ---------- [Translation] Adding the ability do dump <notes> in xliff2.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | n/a The Xliff2.0 dumper do not dump notes. The note section is the only place (as far as I can see) you can add arbitrary data. See [specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html). This will be useful when you want to add data like "approved", "status" etc. I can see from the test code that a previous author intends to use attributes to the <target> for such data. That is [not allowed](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#target), not even with a custom namespace. If you want to validate my test fixture, here is the validator: http://okapi-lynx.appspot.com/validation Commits ------- c4dd11c [Translation] Adding the ability do dump <notes> in xliff2.0
|
Awesome. Thank you for merging. |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2017
…iff2.0 (Nyholm) This PR was squashed before being merged into the 3.4 branch (closes #23947). Discussion ---------- [Translation] Adding the ability do load <notes> in xliff2.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | ~~~~yes~~~ no (sorry) | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #23890 we can dump `<notes>`. We should also have the ability to load them back. Commits ------- b0cdb53 [Translation] Adding the ability do load <notes> in xliff2.0
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Xliff2.0 dumper do not dump notes. The note section is the only place (as far as I can see) you can add arbitrary data. See specification.
This will be useful when you want to add data like "approved", "status" etc. I can see from the test code that a previous author intends to use attributes to the for such data. That is not allowed, not even with a custom namespace.
If you want to validate my test fixture, here is the validator: http://okapi-lynx.appspot.com/validation