[Mailer] Extract transport factory and allow create custom transports #31946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Mailer/Transport/AbstractTransportFactory.php
Outdated
Show resolved
Hide resolved
ajgarlag
reviewed
Jun 10, 2019
fabpot
added a commit
that referenced
this pull request
Jun 11, 2019
…rom Component to Contracts (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Changed EventDispatcherInterface dependency from Component to Contracts | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | almost yes, see #31956 (comment) | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #31946 (comment) . I hope this kind of changes are allowed for experimental components. BTW, @nicolas-grekas , why Psr14 interface is optional for Contract's `EventDispatcherInterface https://github.com/symfony/symfony/blob/4.4/src/Symfony/Contracts/EventDispatcher/EventDispatcherInterface.php#L16 ? Commits ------- bdb6217 Changed EventDispatcherInterface dependency from Component to Contracts
816f403 to
9af7d94
Compare
onEXHovia
reviewed
Jun 12, 2019
fabpot
requested changes
Jun 29, 2019
c03a91a to
510bd0b
Compare
|
@fabpot I've fixed comments from code review. Now working on adding tests (I've updated TODO list in PR header) |
593acbc to
02aa069
Compare
fabpot
requested changes
Jul 1, 2019
2b8200a to
f542f6f
Compare
|
I've fixed tests and removed BC-breaks, so bc-break label non-actual anymore. More tests for all factories should be added, but I need 1 week more due to vacation. BTW PR is ready for another round of review. |
fabpot
approved these changes
Jul 8, 2019
src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php
Outdated
Show resolved
Hide resolved
aea9b37 to
a016fc2
Compare
29d9a30 to
5029ed6
Compare
Koc
commented
Jul 14, 2019
Koc
commented
Jul 14, 2019
|
Not sure if this PR is ready now but fabbot has an interesting patch to apply. |
|
Almost ready. Failure caused because #32553 not merged yet. |
1d701e1 to
5b9cded
Compare
|
Finally PR is ready 🎉 Travis is green except |
fabpot
approved these changes
Jul 17, 2019
|
Thank you @Koc. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2019
…stom transports (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Extract transport factory and allow create custom transports | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes, failure unrelated (master hasn't this PR) | Fixed tickets | #31385, #32523 | License | MIT | Doc PR | TBD Alternative approach to allow create custom transports and register DSN for it. Replaces #31931, #31935 . Similar to already existent TansportFactory from Messenger. TODO: - [x] Update changelog - [x] Add more tests for factories - [x] Add test for configuration + DI extension Commits ------- 5b9cded Add transport factories (closes #31385, closes #32523)
stof
reviewed
Jul 17, 2019
| } | ||
|
|
||
| $user = urldecode($parsedDsn['user'] ?? null); | ||
| $password = urldecode($parsedDsn['pass'] ?? null); |
There was a problem hiding this comment.
this is broken. It is passing null to urldecode, and it won't get null as $user then.
There was a problem hiding this comment.
But it already covered with test https://github.com/symfony/symfony/pull/31946/files#diff-e3a1e78245b60fed36ed6ab4e56023ceR48 . Strange. Maybe because assertEquals compares '' equal to null
There was a problem hiding this comment.
@Koc assertEquals() does not make a strict comparison unlike assertSame(). It is therefore recommended to use assertSame() (or assertNull() to check the null value).
This was referenced Jul 18, 2019
fabpot
added a commit
that referenced
this pull request
Jul 25, 2019
…es (Koc) This PR was squashed before being merged into the 4.4 branch (closes #32609). Discussion ---------- [Mailer][DX][RFC] Rename mailer bridge transport classes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yno | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - During working on #31946 I realized how painful to work with multiple classes which has same name. [Nice article](https://www.tomasvotruba.cz/blog/2019/05/02/alias-as-a-code-smell/) by @TomasVotruba with explanation of problems with such approach. ~Built on top of #32608 , so only [2nd commit](bbf7e99) is actual.~ Also I've changed namespaces to make bridge structure much simpler and be linear. All classes located on same level now. See how [bridge](https://github.com/symfony/symfony/tree/bbf7e99e89c70fab372929827ae509b41280ce40/src/Symfony/Component/Mailer/Bridge/Amazon) looks like now. Now in RFC state to get approve for such king of changes and update all other bridges. Commits ------- eda4f01 [Mailer][DX][RFC] Rename mailer bridge transport classes
This was referenced Nov 12, 2019
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 18, 2024
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- [Mailer] Add custom transport factories This might be useful for very custom use cases where we need to extract some data or do something before being able to create the actual transport. The feature apparently was added here: symfony/symfony#31946 Commits ------- 72b69c1 [Mailer] Add custom transport factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to allow create custom transports and register DSN for it. Replaces #31931, #31935 . Similar to already existent TansportFactory from Messenger.
TODO: