Skip to content

[Messenger] Allow exchange type headers binding #32489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Jul 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29983
License MIT
Doc PR ø

Taken over #29983, as a feature for 4.4. Apparently useful.

@sroze
Copy link
Contributor Author

sroze commented Jul 10, 2019

(failure is unrelated)

@sroze sroze force-pushed the amqp-bind-exchange-arguments branch from 6d482a5 to 195450e Compare July 11, 2019 07:23
@nicolas-grekas nicolas-grekas added this to the next milestone Jul 11, 2019
@fabpot
Copy link
Member

fabpot commented Aug 9, 2019

@sroze Is it ready? /cc @Tobion

@sroze sroze force-pushed the amqp-bind-exchange-arguments branch from 195450e to 3211caa Compare August 18, 2019 16:49
@fabpot
Copy link
Member

fabpot commented Aug 18, 2019

Thank you @sroze.

fabpot added a commit that referenced this pull request Aug 18, 2019
…ckOka)

This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Allow exchange type headers binding

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29983
| License       | MIT
| Doc PR        | ø

Taken over #29983, as a feature for 4.4. [Apparently useful](https://www.cloudamqp.com/blog/2015-09-03-part4-rabbitmq-for-beginners-exchanges-routing-keys-bindings.html).

Commits
-------

3211caa Allow exchange type headers binding
@fabpot fabpot merged commit 3211caa into symfony:4.4 Aug 18, 2019
@CedrickOka
Copy link
Contributor

Thanks you @sroze

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants