-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Allow exchange type headers binding #32489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(failure is unrelated) |
Tobion
reviewed
Jul 11, 2019
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/ConnectionTest.php
Outdated
Show resolved
Hide resolved
Tobion
reviewed
Jul 11, 2019
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/ConnectionTest.php
Outdated
Show resolved
Hide resolved
6d482a5
to
195450e
Compare
195450e
to
3211caa
Compare
fabpot
approved these changes
Aug 18, 2019
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
…ckOka) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Allow exchange type headers binding | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29983 | License | MIT | Doc PR | ø Taken over #29983, as a feature for 4.4. [Apparently useful](https://www.cloudamqp.com/blog/2015-09-03-part4-rabbitmq-for-beginners-exchanges-routing-keys-bindings.html). Commits ------- 3211caa Allow exchange type headers binding
Thanks you @sroze |
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken over #29983, as a feature for 4.4. Apparently useful.