Btw we could do evern more refactoring, but I want to preserve BC even for those who extend the Dumper class.

E.g. we could have the main ->dump() method be called only for the top level, and then use a different ->dumpRecursive() method. But this would break extending classes.

I also would like to have an option to save a line break for map inside sequence as requested in #15782. But better do this in a follow-up.

Fails seem unrelated.

Can you send the extension of the existing tests as a separate PR against the 4.4 branch please?

#46739

#46739 is now merged up to 6.2. Can you please rebase this PR?
Note that it'd be great to fix those @todo before merging, on 4.4 also.

Status: needs work.

@nicolas-grekas
Thanks!
What is a good base to rebase on?
We want to merge this into all branches later, right?

If I rebase on 4.4, do we want to support PHP 7.1?
The composer.json says so.
With 7.1 we cannot even use composer2 :)
But maybe this is exactly the point, to support legacy projects.

I am not sure if we actually do want to go for 4.4, so I make that a separate PR and we can choose.

Any reactorting must be done in 6.2.

I fail to see the added benefit these changes bring, thus 👎 from my side on these changes