-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Move Router cache directory to kernel.build_dir
#52962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel.build_dir
ccb46eb
to
4d9a4b0
Compare
nicolas-grekas
approved these changes
Dec 10, 2023
4d9a4b0
to
10fcb66
Compare
fabpot
approved these changes
Dec 13, 2023
Thank you @Okhoshi. |
10fcb66
to
1f031f8
Compare
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 9, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [FrameworkBundle] Update `cache_dir` config Update the documentation on configuration of the FrameworkBundle to reflect the deprecation of `cache_dir` (done in symfony/symfony#52962) and the introduction of `ignore_cache` (from symfony/symfony#53059). Fixes #19281 Ping `@alexandre`-daubois Commits ------- 47e0be0 [FrameworkBundle] Update cache_dir config
Merged
This was referenced Jun 27, 2024
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [FrameworkBundle] Fix warming up routes | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follows #52962 and builds on the semantics of #57553. Commits ------- cc918e9 [FrameworkBundle] Fix warming up routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #50391, set up Router cache directory to
kernel.build_dir
instead ofkernel.cache_dir
by default, and only warm the cache on read-only resources phase.#SymfonyHackday