-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] fix DateTypeTest.php #52967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form] fix DateTypeTest.php #52967
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Can you please check which ICU version you have? |
I have this version: uconv v2.1 ICU 72.1 |
Thanks for making us aware of this @toxicity1985. I suggest we skip these five tests with ICU 72.1 too (see #53335). |
…2.1 (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Form] skip some tests that do not work with ICU 71.1/72.1 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | replaces #52967 | License | MIT Commits ------- 8ef61d9 skip some tests that do not work with ICU 71.1/72.1
It seems there is a bug until the most recent ICU version (74), so it may concern all ICU versions < 74.2 ICU 74.2 release notes:
Bug issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1864612#c8 As it may concern a lot of users, should we (can we) create a temporary patch ? cc @xabbuh |
For me, tests pass locally with ICU 73.1. So not sure if that's the same issue. |
@xabbuh ok! I’ll investigate tomorrow and see if there is something here that impact us |
Hello,
When I launch my test on my laptop, i was having some issue with the DateTypeTest.
Here is my fixes.
Best regards.