Skip to content

[Form] fix DateTypeTest.php #52967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

toxicity1985
Copy link

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

image

Hello,

When I launch my test on my laptop, i was having some issue with the DateTypeTest.
Here is my fixes.

Best regards.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [FORM] fix DateTypeTest.php [Form] fix DateTypeTest.php Dec 9, 2023
@yceruto
Copy link
Member

yceruto commented Dec 9, 2023

Duplicated of #52792? Shouldn't it have already been fixed by #52245? /cc @xabbuh

@xabbuh
Copy link
Member

xabbuh commented Dec 9, 2023

Can you please check which ICU version you have?

@toxicity1985
Copy link
Author

I have this version:

uconv v2.1 ICU 72.1

@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2023

Thanks for making us aware of this @toxicity1985. I suggest we skip these five tests with ICU 72.1 too (see #53335).

xabbuh added a commit that referenced this pull request Jan 1, 2024
…2.1 (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Form]  skip some tests that do not work with ICU 71.1/72.1

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | replaces #52967
| License       | MIT

Commits
-------

8ef61d9 skip some tests that do not work with ICU 71.1/72.1
@xabbuh xabbuh closed this Jan 1, 2024
@smnandre
Copy link
Member

smnandre commented Jan 1, 2024

It seems there is a bug until the most recent ICU version (74), so it may concern all ICU versions < 74.2
(almost the same we had with emojis)

ICU 74.2 release notes:

Important: DateFormat.getInstanceForSkeleton() and the DateTimePatternGenerator sometimes used the wrong patterns because they failed to use/inherit certain data. (ICU-22575 — CLDR 44 had removed some redundant data that ICU relied on.)
--> ICU 74 : https://icu.unicode.org/download/74

Bug issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1864612#c8

As it may concern a lot of users, should we (can we) create a temporary patch ?

cc @xabbuh

@xabbuh
Copy link
Member

xabbuh commented Jan 2, 2024

For me, tests pass locally with ICU 73.1. So not sure if that's the same issue.

@toxicity1985 toxicity1985 deleted the 5.4 branch January 2, 2024 12:36
@smnandre
Copy link
Member

smnandre commented Jan 2, 2024

@xabbuh ok! I’ll investigate tomorrow and see if there is something here that impact us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants