Skip to content

[Messenger] Add --format option to the messenger:stats command #57426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

xvilo
Copy link
Contributor

@xvilo xvilo commented Jun 17, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #48583
License MIT

As requested in #48583 add a way to output different in formats for messenger:stats command. This can be more easily used in, for example, jq or with external automations/scripts and such.

Considerations I made:

  • To not, yet, make different classes for the output. In case a new output format is added this might be handy.
  • To not use an enum for output format, do we want this?
  • To ignore warnings for now, except for the uncountable_transports. If we want to warning in there, what format?

@xvilo xvilo marked this pull request as ready for review June 17, 2024 12:40
@carsonbot carsonbot added this to the 7.2 milestone Jun 17, 2024
@symfony symfony deleted a comment from carsonbot Jun 17, 2024
@symfony symfony deleted a comment from carsonbot Jun 17, 2024
@carsonbot carsonbot changed the title Feat/messenger stats output format [Messenger] Feat/messenger stats output format Jun 17, 2024
@OskarStark OskarStark changed the title [Messenger] Feat/messenger stats output format [Messenger] stats output format Jun 17, 2024
@xvilo xvilo requested a review from OskarStark June 17, 2024 21:01
@xvilo xvilo force-pushed the feat/messenger-stats-output-format branch from d4b422b to 9babdc7 Compare June 21, 2024 09:24
@nicolas-grekas nicolas-grekas changed the title [Messenger] stats output format [Messenger] Add --format option to the messenger:stats command Jun 21, 2024
@xvilo xvilo force-pushed the feat/messenger-stats-output-format branch from fd00695 to 2ac11c4 Compare June 22, 2024 10:51
@xvilo xvilo requested a review from nicolas-grekas June 22, 2024 10:51
@xvilo xvilo force-pushed the feat/messenger-stats-output-format branch from 322a672 to 184f35e Compare June 22, 2024 10:54
@xvilo
Copy link
Contributor Author

xvilo commented Jun 22, 2024

I see there are several failing tests, I expect them to be unrelated to this Merge Request. Can I leave them as is? In this case it's Symfony\Bridge\Doctrine\Tests\ManagerRegistryTest::testResetService

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures unrelated.

@fabpot fabpot force-pushed the feat/messenger-stats-output-format branch from 184f35e to 0e9f458 Compare June 25, 2024 06:00
@fabpot
Copy link
Member

fabpot commented Jun 25, 2024

Thank you @xvilo.

@fabpot fabpot merged commit ce67e41 into symfony:7.2 Jun 25, 2024
5 of 10 checks passed
@OskarStark OskarStark removed their request for review June 25, 2024 07:07
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Messenger] Add machine readable (e.g. JSON) output format to messenger:stats command
5 participants