-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Add --format
option to the messenger:stats
command
#57426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 17, 2024
d4b422b
to
9babdc7
Compare
--format
option to the messenger:stats
command
fd00695
to
2ac11c4
Compare
322a672
to
184f35e
Compare
I see there are several failing tests, I expect them to be unrelated to this Merge Request. Can I leave them as is? In this case it's |
nicolas-grekas
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failures unrelated.
fabpot
approved these changes
Jun 25, 2024
184f35e
to
0e9f458
Compare
Thank you @xvilo. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #48583 add a way to output different in formats for
messenger:stats
command. This can be more easily used in, for example,jq
or with external automations/scripts and such.Considerations I made:
uncountable_transports
. If we want to warning in there, what format?