Skip to content

[Mailer] [sendgrid-mailer] Fix null check on region #59099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

AUDUL
Copy link
Contributor

@AUDUL AUDUL commented Dec 5, 2024

Fix region null check

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Issue :
Nullable check on region is wrong.

Fix region null check
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Dec 6, 2024

Thank you @AUDUL.

@fabpot fabpot merged commit 6076b87 into symfony:7.2 Dec 6, 2024
9 of 10 checks passed
@xabbuh xabbuh mentioned this pull request Dec 6, 2024
1 task
@xabbuh xabbuh added the Mailer label Dec 7, 2024
@carsonbot carsonbot changed the title [sendgrid-mailer] Fix null check on region [Mailer] [sendgrid-mailer] Fix null check on region Dec 7, 2024
nicolas-grekas added a commit that referenced this pull request Dec 7, 2024
This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer] add test covering null regions

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

even if the fix in #59102 was a duplicate of #59099 having the test IMO is still a good idea

Commits
-------

91f4a2c add test covering null regions
@fabpot fabpot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants