Skip to content

[Config] #7644 add tests for passing number looking attributes as strings #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

cordoval
Copy link
Contributor

Q A
Bug fix? yes
New feature no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7644
License MIT

@stloyd
Copy link
Contributor

stloyd commented Apr 12, 2013

You mentioned wrong issue in description, should be #7644.

@cordoval
Copy link
Contributor Author

i fixed it thanks, damage has been done @stloyd though

@fabpot
Copy link
Member

fabpot commented Apr 12, 2013

But this is only a test, so it cannot be fixed, right?

@cordoval
Copy link
Contributor Author

@fabpot exactly it is a missusage, the test clarifies the way to achieve this

@fabpot
Copy link
Member

fabpot commented Apr 12, 2013

I don't get it. It he wants his attribute to be '1,2,3,4', it seems legitimate to me and it is clearly not a number.

@cordoval
Copy link
Contributor Author

@fabpot he does not want a 1,2,3,4 which is a string humanly noticeable
he wants to imitate the 123,456 notation which pertains to numbers units, thousands, millions, billions, etc.
That notation is reserved to numbers only, therefore he must use a workaround with spaces. There is no harm on spaces he can later just use php ability to just parse it.

@cordoval
Copy link
Contributor Author

@fabpot solved 👍

@Seldaek
Copy link
Member

Seldaek commented Apr 12, 2013

Seems fine, although it is madness that we allow "," as thousand separator in there at all IMO. I'd rather see this fixed, but I am not sure what this code is used for and what the impact would be.

How about you do an integer list and depending on the integers you have, they're either parsed as a string (integer list) or a float (thousand separators)? Sounds inconsistent and very error prone.

@cordoval
Copy link
Contributor Author

@fabpot @Seldaek after reading this http://stackoverflow.com/questions/13553933/define-symfony-2-tag-attribute-as-an-array-in-xml-configuration now i understand what needs to happen, everything with , should be rendered as a string.

fabpot added a commit that referenced this pull request Apr 20, 2013
This PR was squashed before being merged into the 2.2 branch (closes #7655).

Discussion
----------

[Config] #7644 add tests for passing number looking attributes as strings

| Q                       | A                 |
| -----------------  |:-------------:|
| Bug fix?            | yes             |
| New feature     | no               |
| BC breaks?     | no               |
| Deprecations?| no               |
| Tests pass?    | yes             |
| Fixed tickets    | #7644        |
| License            | MIT            |

Commits
-------

d98118a [Config] #7644 add tests for passing number looking attributes as strings
@fabpot fabpot closed this Apr 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants