-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Config] #7644 add tests for passing number looking attributes as strings #7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cordoval
commented
Apr 12, 2013
Q | A |
---|---|
Bug fix? | yes |
New feature | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #7644 |
License | MIT |
You mentioned wrong issue in description, should be #7644. |
i fixed it thanks, damage has been done @stloyd though |
But this is only a test, so it cannot be fixed, right? |
@fabpot exactly it is a missusage, the test clarifies the way to achieve this |
I don't get it. It he wants his attribute to be '1,2,3,4', it seems legitimate to me and it is clearly not a number. |
@fabpot he does not want a |
@fabpot solved 👍 |
Seems fine, although it is madness that we allow "," as thousand separator in there at all IMO. I'd rather see this fixed, but I am not sure what this code is used for and what the impact would be. How about you do an integer list and depending on the integers you have, they're either parsed as a string (integer list) or a float (thousand separators)? Sounds inconsistent and very error prone. |
@fabpot @Seldaek after reading this http://stackoverflow.com/questions/13553933/define-symfony-2-tag-attribute-as-an-array-in-xml-configuration now i understand what needs to happen, everything with |
This PR was squashed before being merged into the 2.2 branch (closes #7655). Discussion ---------- [Config] #7644 add tests for passing number looking attributes as strings | Q | A | | ----------------- |:-------------:| | Bug fix? | yes | | New feature | no | | BC breaks? | no | | Deprecations?| no | | Tests pass? | yes | | Fixed tickets | #7644 | | License | MIT | Commits ------- d98118a [Config] #7644 add tests for passing number looking attributes as strings