[console] makes descriptors use output instead of returning a string #8451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfsimon Thanks. you are the best ;) |
| } | ||
|
|
||
| $blocks[] = implode("\n", array_map(function ($commandName) { | ||
| $this->write("\n\n"); | ||
| $this->write(implode("\n", array_map(function ($commandName) { |
There was a problem hiding this comment.
you ould simplify this: $output->write() accepts an arrat of lines too
This was referenced Jul 10, 2013
This was referenced Jul 11, 2013
| @@ -0,0 +1,37 @@ | |||
| <?php | |||
|
|
|||
[console] made descriptors use output instead of returning a string [console] updated descriptors usage [console] fixed descriptors usage & tests [console] applied advices from github [Console] applied advices from github updated changelog
fabpot
added a commit
that referenced
this pull request
Jul 31, 2013
This PR was merged into the master branch. Discussion ---------- [console] makes descriptors use output instead of returning a string This PR changes `DescriptorInterface::describe($object, array $options = array())` method signature to `describe(OutputInterface $output, $object, array $options = array())` and all subsequent implementations. It's now possible to use helpers inside descriptors. That was not easy! @lyrixx this is all for you @fabpot I just added one new class | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8371 Commits ------- b9fa52c [Console] made descriptors use output instead of returning a string
|
Thanks @jfsimon |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
DescriptorInterface::describe($object, array $options = array())method signature todescribe(OutputInterface $output, $object, array $options = array())and all subsequent implementations.It's now possible to use helpers inside descriptors.
That was not easy!
@lyrixx this is all for you
@fabpot I just added one new class