Skip to content

Update CONTRIBUTORS.md #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update CONTRIBUTORS.md #9404

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2013

  • Privacy issue

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

This file is auto-generated, based on the information you gave on Github and SensioLabsConnect. That's where the changes must be done.

@fabpot fabpot closed this Oct 30, 2013
@ghost
Copy link
Author

ghost commented Oct 30, 2013

The account on github doesn't exists anymore and I never subscribed to SensioLabConnect

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

Your name comes from 0a26641, so this is public information.

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

And your name is also in the original PR: #7963

@ghost
Copy link
Author

ghost commented Oct 30, 2013

Thank you. I supposed github replaced every things with "ghost". I supposed wrong.
Now its up to github.

@Tobion
Copy link
Contributor

Tobion commented Oct 30, 2013

It cannot be made anonymous. Your name and email was part of the commit which cannot be changed anymore. So github cannot do anything as well.

@ghost
Copy link
Author

ghost commented Oct 30, 2013

@Tobion Is expected by law almost in every country.

@Tobion
Copy link
Contributor

Tobion commented Oct 30, 2013

Well, then ask Github what they can do about it. I'm curios about their response ^^

@aderuwe
Copy link
Contributor

aderuwe commented Oct 30, 2013

I would say the permission was implicit when you yourself pushed the commit to Github...

@ghost
Copy link
Author

ghost commented Oct 30, 2013

@Tobion I already asked. I let you know :)
@aderuwe I haven't read their tos/toc but I don't think they said somethings like "One commit is forever'

@stof
Copy link
Member

stof commented Oct 30, 2013

@banano1 it is not specific to github. It is the way git itself works

@ghost
Copy link
Author

ghost commented Oct 30, 2013

@stof I know. They think that I'm gonna rebase --amend --reset I don't know which operation I can do just because a software works like that? I don't care. Are my rights and my name

@ghost
Copy link
Author

ghost commented Oct 30, 2013

And If I'm gonna send a law enforcement they'll not gonna answer: is how git works, ask Linus

@stof
Copy link
Member

stof commented Oct 30, 2013

@banano1 Rewriting the history of a commit requires changing the history of the whole project after this commit and redoing all releases, meaning it breaks all projects depending on a commit done after this (as it will remove them from the history to replace them by different commits). I doubt Fabien wants to break all projects relying on Symfony for this.

@cordoval
Copy link
Contributor

@banano1 i think the wise solution is to write a script to change that line on the contributors.md to a blur name. People will look more into contributors.md and not in the sha history too much, so that can be left. The contributors.md was the thing that needs to get changed. @fabpot i think work can be devoted to write that built-in to the automated script you have without much hassle. Then everybody is happy and rights are respected.

@pborreli
Copy link
Contributor

@cordoval don't forget http://symfony.com/contributors/code too 👀

@ghost
Copy link
Author

ghost commented Oct 30, 2013

@cordoval Don't mislead my tone. I'm super easy. It's just unbelievable that every clone of symfony under a document_root shows my name. Just for one commit I've 5 pages on google. Just because I did a commit with wrong account. But now I learned that every time I need to submit something I create a new one.

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

@cordoval I wanted to point out that even if we remove the name from the contributor file (which is the only thing we can do really), it will still be in the history, and as such still present on Github, parseable by Google, ...

@ghost
Copy link
Author

ghost commented Oct 30, 2013

@stof If Martin mcfly was able to do that I'm able too

@cordoval
Copy link
Contributor

@fabpot i agree, so doing that i hope @banano1 will feel better and know that we did all that was possible in our side and that it was reasonable in view of his mistake. It will definitely help.

@ghost
Copy link
Author

ghost commented Oct 30, 2013

Thank you I really appreciate.

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

http://symfony.com/contributors/code has been updated now.

@fabpot
Copy link
Member

fabpot commented Oct 30, 2013

And your name is now removed from the CONTRIBUTORS file: eac8e3a#diff-f0eaedffe49f98e11072394a678af7ccL783

@monti1
Copy link

monti1 commented Nov 4, 2013

@fabpot Thankyou!
@stof Actually they answer me that they'll submit the issue to Linus :). They probably read this pull req.

@martirio
Copy link

martirio commented Nov 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants