-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Update CONTRIBUTORS.md #9404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTORS.md #9404
Conversation
ghost
commented
Oct 29, 2013
- Privacy issue
This file is auto-generated, based on the information you gave on Github and SensioLabsConnect. That's where the changes must be done. |
The account on github doesn't exists anymore and I never subscribed to SensioLabConnect |
Your name comes from 0a26641, so this is public information. |
And your name is also in the original PR: #7963 |
Thank you. I supposed github replaced every things with "ghost". I supposed wrong. |
It cannot be made anonymous. Your name and email was part of the commit which cannot be changed anymore. So github cannot do anything as well. |
@Tobion Is expected by law almost in every country. |
Well, then ask Github what they can do about it. I'm curios about their response ^^ |
I would say the permission was implicit when you yourself pushed the commit to Github... |
@banano1 it is not specific to github. It is the way git itself works |
@stof I know. They think that I'm gonna rebase --amend --reset I don't know which operation I can do just because a software works like that? I don't care. Are my rights and my name |
And If I'm gonna send a law enforcement they'll not gonna answer: is how git works, ask Linus |
@banano1 Rewriting the history of a commit requires changing the history of the whole project after this commit and redoing all releases, meaning it breaks all projects depending on a commit done after this (as it will remove them from the history to replace them by different commits). I doubt Fabien wants to break all projects relying on Symfony for this. |
@banano1 i think the wise solution is to write a script to change that line on the contributors.md to a blur name. People will look more into contributors.md and not in the sha history too much, so that can be left. The contributors.md was the thing that needs to get changed. @fabpot i think work can be devoted to write that built-in to the automated script you have without much hassle. Then everybody is happy and rights are respected. |
@cordoval don't forget http://symfony.com/contributors/code too 👀 |
@cordoval Don't mislead my tone. I'm super easy. It's just unbelievable that every clone of symfony under a document_root shows my name. Just for one commit I've 5 pages on google. Just because I did a commit with wrong account. But now I learned that every time I need to submit something I create a new one. |
@cordoval I wanted to point out that even if we remove the name from the contributor file (which is the only thing we can do really), it will still be in the history, and as such still present on Github, parseable by Google, ... |
@stof If Martin mcfly was able to do that I'm able too |
Thank you I really appreciate. |
http://symfony.com/contributors/code has been updated now. |
And your name is now removed from the CONTRIBUTORS file: eac8e3a#diff-f0eaedffe49f98e11072394a678af7ccL783 |