-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
PHP 7.1.3 is required by all Symfony 4.* versions not only by Symfony 4.0 #10732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR was merged into the master branch. Discussion ---------- add XML and PHP config examples Commits ------- dc2bda4 add XML and PHP config examples
* 4.1: Simplified the "Release Process" page [Workflow] Fix typo documentation Fix mismatched list items typos in sample code [#9988] fix minor typos [#10099] update XML and PHP config examples [#9969] fix a minor typo [#10022] fix a minor typo preUpdate Event Listener On Uploaded Imagery [#9757] fix rst syntax [#10124] fix XML attribute name [#10062] fix the code block [PHPUnitBridge] Explain how to show stack traces Fix docs on trusted hosts opcode optimizations
* 4.1: Remove references to Silex Removing outdated note: AJAX requests are not set to target path Fixed some minor issues server fails to run on this tutorial fix XML attribute name fix cache option data type
* 4.1: added a space before "=" in code fix the markup Changing to absolute url, as requested Updated link to Event Listeners page Update form_customization.rst Revert "Fix typo on which YAML values must not be quoted" Fix typo (shard -> shared) Fix typo on which YAML values must not be quoted Change all occurrences of Controller to AbstractController fix `HandlerLocator`'s use statement
* 4.1: minor fixes Shorter array syntax for declaring numbers variable Twig is included with Symfony. No need to have the user run composer The `profiler-pack` is included in the composer package. It can be a bit confusing to the user with the extra stuff showing on the screen. Move the controller tip out of the annotation routes.
* 4.1: {% if label is not same as(false) and required %} minor language tweak Update service_container.rst Fix wrong exception used in custom authentication provider example [Console] Replace useless usage of ContainerAwareCommand Shorten ternary operator Fix wrong usage in custom authenticator checking if password is invalid [Process] Fix typo in Process object initialization update hardcoded 5.1 version link Explain dump server usage outside of Symfony Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component Update bugs.rst [#10200] remove trailing spaces action_method is missing $task variable [#10177] fix markup Clarifying when you need to or don't need to install the server bundle Fix bad link Update setup.rst Also requiring annotations so they can be used
* 4.1: remove acl Small fix to syntax Assume the user is using Flex when deploying
* 4.1: Updated the doc link Update PHPUnit documentation link Move range to the comparison constraint types Update link to use latest docs Removed an unnecessary comment Added a tip about versioning when using Flex Use SCSS instead of CSS for code block Fix minor typo in the_big_picture.rst Removing calls to deprecated code [HttpFoundation] Small fixes on some examples Fixed Modifying Rendered Tables example Broken nginx XSendfile link
…s (thewilkybarkid, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Update translator fallback example to include ICU parents Changes the example to show symfony/symfony#28070. Commits ------- 7ccf603 Reworded and added the versionadded directive 54631df Update translator fallback example to include ICU parents
…s (Thomas Calvet, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Routing] Add locale fallback to internationalized routes Related PR : symfony/symfony#27957 Commits ------- 02cc739 Minor reword c15df9d [Routing] Add locale fallback to internationalized routes
…luz) This PR was merged into the master branch. Discussion ---------- Document the DotEnv::overload() method I'm not sure how to update the doc according my PR symfony/symfony#26859 which is pending review but feel free to comment if I did a mistake. Thank you. Commits ------- 38e4f08 Reword f8a3c0d Update dotenv.rst 6325759 Update dotenv.rst c8ad296 Update dotenv.rst
This PR was merged into the master branch. Discussion ---------- Documenting debug:twig command See symfony/symfony#27981 Commits ------- 1026020 Documenting debug:twig command
…ell) This PR was merged into the master branch. Discussion ---------- [Validator] Document the DivisibleBy constraint Documentation for the new ~`MultipleOf`~ `DivisibleBy` constraint proposed in symfony/symfony#28069 Commits ------- 3270cca Document the DivisibleBy constraint
* 4.1: [Messenger] Error in XML configuration ! prefix referencing templates [Messenger] Fix syntax of Return Type Declaration Small fix to syntax of Return Type Declaration remove changelog toctree entry removed the changelog file removed Romain as part of the core team Update deployment.rst Fixed underline Adding check for environments Added pre-deployment tasks and removed Assetic deployment Added reference to deploying assets
* 4.1: stop using the deprecated @method annotation
This PR was squashed before being merged into the master branch (closes #9875). Discussion ---------- Add Lock's PdoStore documentation Documenting symfony/symfony#27456 Commits ------- 20511e8 Add Lock's PdoStore documentation
* 4.1: moving bootstrap.php to config
* 4.1: Enhance messenger doc
* 4.1: change targetEntity format Less code Wrong function name
* 4.1: Fixed the TOC of the main Forms article Framework configuration > Cache pools > Fix FQCN Duplicate composer require in Your First Functional Test chapter [#10401] fix markup Rename UserFixture to UserFixtures Reworded the caution message
…fault value (osavchenko) This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #10695). Discussion ---------- [Serializer] Deprecate CsvEncoder as_collection false default value Resolves #10337 Commits ------- aa63ff6 Add deprecation message for as_collection parameter of CsvEncoder serializer
* 4.1: Teach the user to write the command lazy loading [#10480] reuse wording from multi kernel article Update Multiple_kernels.rst Update usage.rst add annotation block to routing conditions fix the markup Clarifying what happens with --env=prod + APP_ENV=prod Fix example for collection form type Update micro_kernel_trait.rst Update configuration/micro_kernel_trait.rst Update to micro_kernel_trait.rst
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #10453). Discussion ---------- Add XML encoder comment tip and docs Fix #10289 - Add docs for encoding / decoding XML comments. - Add docs for additional XMLEncoder class constructor argument for ignoring comment encoding Commits ------- 9e3910a Add XML encoder comment tip and docs
… method (andrey-helldar) This PR was squashed before being merged into the master branch (closes #10646). Discussion ---------- [DomCrawler] Added return of element name in `extract()` method See a PR: symfony/symfony#29127 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b89cd59 [DomCrawler] Added return of element name in `extract()` method
`get` was replaced with `last`: symfony/messenger@7ae60a2
It looks like the HandlerLocator is replaced with the HandlersLocator in 4.2.
This PR was merged into the 4.2 branch. Discussion ---------- Update the example how to fetch an envelope stamp `get` was replaced with `last`: symfony/messenger@7ae60a2 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 9347ccb Update the example how to fetch an envelope stamp
* 4.1: Switch to 3.4 as oldest maintained branch Minor tweaks Changing the wording around module.exports FIX: Clarify best_practices/creating-the-project.rst
* 4.2: Update the example how to fetch an envelope stamp Switch to 3.4 as oldest maintained branch Changing the wording around module.exports FIX: Clarify best_practices/creating-the-project.rst
… (j92) This PR was merged into the 4.2 branch. Discussion ---------- Use the new HandlersLocator and initialise it correctly. It looks like the HandlerLocator is replaced with the HandlersLocator in 4.2. Here you can check the initialisation of the `HandlersLocator`: https://github.com/symfony/symfony/blob/4.2/src/Symfony/Component/Messenger/Tests/Handler/HandlersLocatorTest.php <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c422cbc Use the new HandlersLocator and initialise it correctly.
* 4.2: Use the new HandlersLocator and initialise it correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Shoplifter, is your PR correct, it looks like you had a bad rebase/merge since I see 250+ commits and 100 file changes.
Sorry, I screwed that up. That was the first time I tried to contribute. See this PR instead |
@Shoplifter don't worry about the bad rebase/merge. It has happened to all of us (and to me, several times 😊). Let's close this in favor of #10733 then. Thanks! |
#10729