Adapted the HTTPlug integration docs to Async Client #12389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Sep 27, 2019
|
Should we add some words about the async method? This one is not superseded by PSR18 and provides a promise-based API, which is a paradigm that could be worth mentioning? |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 7, 2019
This PR was squashed before being merged into the 4.4 branch (closes #33743). Discussion ---------- [HttpClient] Async HTTPlug client | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #33710, Fix #32142 | License | MIT | Doc PR | symfony/symfony-docs#12389 This PR removes `HttplugClient`'s dependency on `Psr18Client`. It will also add an `HttplugPromise` to make sure we sure we respect the Httplug's `HttpAsyncClient` interface. It implements `HttpAsyncClient::sendAsyncRequest()` and provides two extensions: - `HttplugPromise::cancel()` allows cancelling a promise (and the underlying response) - `HttplugClient::wait()` allows to tick the promise pool, with configurable timeouts. Commits ------- 4fd593f [HttpClient] Async HTTPlug client
symfony-splitter
pushed a commit
to symfony/http-client
that referenced
this pull request
Oct 7, 2019
This PR was squashed before being merged into the 4.4 branch (closes #33743). Discussion ---------- [HttpClient] Async HTTPlug client | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #33710, Fix #32142 | License | MIT | Doc PR | symfony/symfony-docs#12389 This PR removes `HttplugClient`'s dependency on `Psr18Client`. It will also add an `HttplugPromise` to make sure we sure we respect the Httplug's `HttpAsyncClient` interface. It implements `HttpAsyncClient::sendAsyncRequest()` and provides two extensions: - `HttplugPromise::cancel()` allows cancelling a promise (and the underlying response) - `HttplugClient::wait()` allows to tick the promise pool, with configurable timeouts. Commits ------- 4fd593f869 [HttpClient] Async HTTPlug client
e785064 to
36ebb12
Compare
36ebb12 to
d353b61
Compare
nicolas-grekas
approved these changes
Oct 14, 2019
|
Thank you for completing this PR. I’m 👍 |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] improve StreamWrapper | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#12389 Spotted while working on the linked doc PR. Commits ------- ea52d1c [HttpClient] improve StreamWrapper
OskarStark
approved these changes
Nov 1, 2019
|
Thank you both 🙏 |
OskarStark
added a commit
that referenced
this pull request
Nov 1, 2019
…holm, nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Adapted the HTTPlug integration docs to Async Client This should be merged with symfony/symfony#33743 Closes #12472 Closes #12475 Commits ------- d353b61 Complete doc for 4.4 features 7295404 Adapted the HTTPlug integration docs to Async Client
sadafrangian3
pushed a commit
to sadafrangian3/Dependency-Injection-http-client
that referenced
this pull request
Nov 2, 2022
This PR was squashed before being merged into the 4.4 branch (closes #33743). Discussion ---------- [HttpClient] Async HTTPlug client | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #33710, Fix #32142 | License | MIT | Doc PR | symfony/symfony-docs#12389 This PR removes `HttplugClient`'s dependency on `Psr18Client`. It will also add an `HttplugPromise` to make sure we sure we respect the Httplug's `HttpAsyncClient` interface. It implements `HttpAsyncClient::sendAsyncRequest()` and provides two extensions: - `HttplugPromise::cancel()` allows cancelling a promise (and the underlying response) - `HttplugClient::wait()` allows to tick the promise pool, with configurable timeouts. Commits ------- 4fd593f869 [HttpClient] Async HTTPlug client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged with symfony/symfony#33743
Closes #12472
Closes #12475