Provides a way to override cache and log folders from the ENV #13819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 12, 2020
…g that new variable (Plopix) This PR was merged into the 5.2-dev branch. Discussion ---------- [APP_CACHE_DIR] Ensure a split per environment when using that new variable | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#13819 All the explanation here: symfony/symfony-docs#13819 Commits ------- 06b793f Ensure a split per environment
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jun 12, 2020
…g that new variable (Plopix) This PR was merged into the 5.2-dev branch. Discussion ---------- [APP_CACHE_DIR] Ensure a split per environment when using that new variable | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#13819 All the explanation here: symfony/symfony-docs#13819 Commits ------- 06b793f59e Ensure a split per environment
xabbuh
reviewed
Jun 12, 2020
xabbuh
approved these changes
Jun 13, 2020
|
Thank you Sébastien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this new feature symfony/symfony#37114.
But I wonder if we have not oversimplified this PR: symfony/symfony#37114
Actually doing the documentation #13787 I figured that with #37114 we removed the important split per
env.In development mode (docker or not) we could definitely have the same project working in N Symfony different environments and this new
APP_CACHE_DIRwill only set the same path for all environments.That would be manageable in the Virtualhost but in CLI that would be a pain to manage.
Also, we could rely on the DotEnv mechanism, but that could be really easy to forget.
I wonder if we should not change the code to: symfony/symfony#37232
Depending on the decisions I will update the doc here.