Skip to content

Complete documentation about mailer integration #14083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2020
Merged

Complete documentation about mailer integration #14083

merged 1 commit into from
Nov 21, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Aug 16, 2020 •
edited
Loading

Close #14066

@l-vo l-vo force-pushed the complete_mailer_integration branch from 2a9f700 to 0cd93b0 Compare August 16, 2020 14:22
@l-vo l-vo mentioned this pull request Aug 16, 2020
Merged
@l-vo l-vo force-pushed the complete_mailer_integration branch 6 times, most recently from a8ed262 to 962111b Compare August 17, 2020 07:12
@fritzmg fritzmg mentioned this pull request Aug 27, 2020
Merged
@wouterj wouterj added this to the 5.2 milestone Oct 3, 2020
@xabbuh xabbuh changed the base branch from master to 5.x October 6, 2020 11:54
@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2020

Should parts of this be merged into the 4.4 branch?

@l-vo
Copy link
Contributor Author

l-vo commented Nov 17, 2020

No message_bus and headers semantic configuration key were added in 5.x. So is the native mailer transport. I will try to fix conflicts tonight :)

@l-vo
Copy link
Contributor Author

l-vo commented Nov 17, 2020

My bad, this PR include mailer configuration which should be available in 4.4. I will do another PR targeting 4.4.

@l-vo l-vo force-pushed the complete_mailer_integration branch 2 times, most recently from 6a54032 to b212f63 Compare November 17, 2020 21:18
@l-vo l-vo mentioned this pull request Nov 17, 2020
Merged
@l-vo
Copy link
Contributor Author

l-vo commented Nov 17, 2020

@xabbuh PR rebased + #14565 created to report changes on 4.4

@l-vo l-vo force-pushed the complete_mailer_integration branch from b212f63 to c05bdff Compare November 19, 2020 20:14
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj
feature #14565 [Mailer] Complete mailer documentation (l-vo)
135a270 
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Complete mailer documentation

Changes of #14083 reported to 4.4.

Commits
-------

074db0d Complete mailer integration
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj
[#14083] Revert mailer.headers option in 4.4 - 5.1
34ad0b7
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj
Merge branch '4.4' into 5.1
b25e17a 
* 4.4:
  [#14083] Revert mailer.headers option in 4.4 - 5.1
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj
Merge branch '5.1' into 5.2
f50e801 
* 5.1:
  [#14083] Revert mailer.headers option in 4.4 - 5.1
@wouterj wouterj changed the base branch from 5.x to 5.2 November 21, 2020 20:04
@wouterj wouterj force-pushed the complete_mailer_integration branch from c05bdff to a389dfb Compare November 21, 2020 20:04
@wouterj wouterj merged commit b1a157b into symfony:5.2 Nov 21, 2020
wouterj added a commit that referenced this pull request Nov 21, 2020
@wouterj
Merge branch '5.2' into 5.x
22cf67a 
* 5.2:
  Complete documentation about mailer integration
  Complete documentation about mailer integration
  [#14083] Revert mailer.headers option in 4.4 - 5.1
@l-vo l-vo deleted the complete_mailer_integration branch November 21, 2020 20:06
@wouterj
Copy link
Member

wouterj commented Nov 21, 2020

Hi @l-vo! So this was quite a merge 😅 Just to let you know what I did:

  • I merged your new 4.4 PR ([Mailer] Complete mailer documentation #14565) and removed the headers setting from it (as it was introduced in 5.2)
  • I added the message_bus to the 5.1 branch (1da6b0b), as I believe that's where it was introduced
  • I merged this PR, minus all changes that were already done in 5.2. I believe both the native protocol and headers option were introduced in 5.2
  • At last, I found Add mailer in framework config reference #14087 which is also from you and had almost the same changes as your new 4.4 branch. I've closed that one, as I believe we both simply forgot about this PR and the changes are now already done.

@wouterj wouterj mentioned this pull request Nov 21, 2020
Closed
@l-vo
Copy link
Contributor Author

l-vo commented Nov 21, 2020

@wouterj oh sorry for the double PR targeting 4.4, I saw this comment and then I forgot I already did a PR targeting 4.4 😅. Thank you for your explanations and your updates on it 👍

OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Nov 25, 2020
@OskarStark
Merge branch '5.1' into 5.2
f956a36 
* 5.1: (31 commits)
  Fix package name for OvhCloud notifier
  Fix wrong key name
  Enhancement: Streamline workflow
  GitHub Actions: use docker container for CI build
  Bus restricting with Interfaces
  Security: add example code which Maker Bundle generated
  [symfony#14550] Reduce nr of lines used for exception
  Section method only in ConsoleOutputInterface
  Added a new troubleshooting section in the maintainer guide
  Removed duplicated line
  Complete documentation about mailer integration
  [symfony#14083] Revert mailer.headers option in 4.4 - 5.1
  Removed 4.3 versionadded directive
  [symfony#14565] Minor formatting fixes
  Updated getParent() description with the why/when (thanks javier!)
  [Form] Added explicit `getParent()` call in types inheritance mechanism
  Added PHP types to the DI related articles
  Added PHP types to the Form related articles
  Added PHP types to the Doctrine related articles
  Tweak
  ...
This was referenced Oct 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Mailer] Add a transport that uses php.ini settings for configuration
4 participants
@l-vo @xabbuh @wouterj @carsonbot